jenkins-contrib-themes / jenkins-neo-theme

A modern flat theme for Jenkins
http://jenkins-contrib-themes.github.io/jenkins-neo-theme/
352 stars 94 forks source link

Disabled and Not Build icons do not exist #6

Closed RockyMM closed 8 years ago

RockyMM commented 8 years ago

image

afonsof commented 8 years ago

This bug was already fixed in jenkins-material-theme: https://github.com/afonsof/jenkins-material-theme/issues/24. We can use the same code to fix it here.

RockyMM commented 8 years ago

That would be awesome. I cannot find commit relating to afonsof/jenkins-material-theme#24, but I'll try.

RockyMM commented 8 years ago

Found it! https://github.com/afonsof/jenkins-material-theme/commit/592ec5e1ee0d8a3ae046d9c0897107ecdeebc3cd

afonsof commented 8 years ago

@RockyMM https://github.com/afonsof/jenkins-material-theme/commit/2a3d9ee75a627778841808c22127a2ea08ff5f26

RockyMM commented 8 years ago

@afonsof although, I would be more happy if different icons were used, but it's better some icons than no icons :)

RockyMM commented 8 years ago

Hey @afonsof I'm quite novice with GitHub workflow, don't hold grudge against me if I did something wrong ;)

afonsof commented 8 years ago

@RockyMM we've discussed about different icons in the other repo. You are right maybe different icons should be be a better solution. I decided to use the same icon because jenkins uses the same icon and it's hard to find good Material Design icons that express different meanings. Anyway I guess we can improve it :smile:

RockyMM commented 8 years ago

@afonsof Yep, just right now is not the best time. Anyways, I completely forgot about disabled icon. I feel a bit challenged creating these PRs :laughing:

RockyMM commented 8 years ago

Now that the PR is merged should we close it?

aarjithn commented 8 years ago

I've merged the pull request as of now. I see the icons has been fixed by @afonsof. We are thinking to merge our code bases, so issues like this can be better addressed rather than being duplicated across both repos.