Closed RockyMM closed 8 years ago
This bug was already fixed in jenkins-material-theme: https://github.com/afonsof/jenkins-material-theme/issues/24. We can use the same code to fix it here.
That would be awesome. I cannot find commit relating to afonsof/jenkins-material-theme#24, but I'll try.
@afonsof although, I would be more happy if different icons were used, but it's better some icons than no icons :)
Hey @afonsof I'm quite novice with GitHub workflow, don't hold grudge against me if I did something wrong ;)
@RockyMM we've discussed about different icons in the other repo. You are right maybe different icons should be be a better solution. I decided to use the same icon because jenkins uses the same icon and it's hard to find good Material Design icons that express different meanings. Anyway I guess we can improve it :smile:
@afonsof Yep, just right now is not the best time. Anyways, I completely forgot about disabled icon. I feel a bit challenged creating these PRs :laughing:
Now that the PR is merged should we close it?
I've merged the pull request as of now. I see the icons has been fixed by @afonsof. We are thinking to merge our code bases, so issues like this can be better addressed rather than being duplicated across both repos.