search

jenkins-infra / account-app

Jenkins Account Management/Sign-up App
http://accounts.jenkins.io/
7 stars 33 forks source link

Run docker image on infra.ci only #339

Closed NotMyFault closed 7 months ago

NotMyFault commented 9 months ago

We don't store creds on ci.j, causing the step to fail every time on ci.jenkins.io. I propose we run this on infra.ci only, from where the image is deployed.

hervelemeur commented 9 months ago

The only downside with that is now you need infra access to check docker builds.

Last time I thought about it I was about to implement a parameter to the shared pipeline function to optionally disable image publication (which AFAIR is the only failing step due to the missing credentials), but I didn't finished it. To be continued?

hervelemeur commented 9 months ago

For ref, I don't remember atm exactly what was missing, shouldn't be that much, just that at that time I switched to another more important subject and didn't came back to it yet: https://github.com/jenkins-infra/pipeline-library/pull/784

I'll take another look in 2024.

Thus my revised review would be a +/-0 on merging this PR, easy to revert if needed.

NotMyFault commented 9 months ago

Isn't that already the case? Images aren't deployed from ci.j, and therefore you can't check the status there at all? Similar to other jobs deploying from infra.ci

hervelemeur commented 9 months ago

Here the important part is to build docker images on a public instance so everyone can check builds logs and debug Dockerfile changes.

Ref:

The current problem from memory and if not mistaken is that the shared pipeline function always build and publish, while it would be nice to keep it only build on ci.j for example.

dduportal commented 9 months ago

+100 with what @hervelemeur said.