jenkins-infra / crawler

tools crawler
26 stars 65 forks source link

JENKINS-68486 - Hashicorp plugins unable to download releases #111

Closed marcjay closed 2 years ago

marcjay commented 2 years ago

Remove the base URL prefix that is being added to the URLs for Hashicorp tools from https://releases.hashicorp.com It appears that the release page used to have relative URLs, but a recent change (apparently in line with https://www.hashicorp.com/blog/announcing-the-hashicorp-releases-api) has caused the URLs to be absolute

marcjay commented 2 years ago

Taking https://releases.hashicorp.com/packer/1.7.0 as an example, the source contains:

<li>
<a data-product="packer" data-version="1.7.0" data-os="linux" data-arch="386" href="https://releases.hashicorp.com/packer/1.7.0/packer_1.7.0_linux_386.zip">packer_1.7.0_linux_386.zip</a>

</li>
<li>
<a data-product="packer" data-version="1.7.0" data-os="linux" data-arch="amd64" href="https://releases.hashicorp.com/packer/1.7.0/packer_1.7.0_linux_amd64.zip">packer_1.7.0_linux_amd64.zip</a>

</li>
<li>
<a data-product="packer" data-version="1.7.0" data-os="linux" data-arch="arm" href="https://releases.hashicorp.com/packer/1.7.0/packer_1.7.0_linux_arm.zip">packer_1.7.0_linux_arm.zip</a>

</li>

The tool-level pages use relative URLs (e.g. https://releases.hashicorp.com/packer) if that's what you're looking at?

michelzanini commented 2 years ago

This is broken on our Jenkins now, just found this PR. Nice work, need this asap to work with Terraform again

daniel-beck commented 2 years ago

The tool-level pages use relative URLs (e.g. https://releases.hashicorp.com/packer) if that's what you're looking at?

🤦 Thanks!

michelzanini commented 2 years ago

@daniel-beck now that this is merged, does it fixes the issue automatically - or will take some time for this to be deployed somewhere and fixed?

daniel-beck commented 2 years ago

Check file timestamps in https://updates.jenkins.io/updates/ ; once they're newer than "now", "Check for updates" in Jenkins.