Add script for dotnet-sdk-plugin downloadables

jenkins-infra / crawler

tools crawler

26 stars 65 forks source link

Add script for dotnet-sdk-plugin downloadables #88

Closed Zastai closed 4 years ago

Zastai commented 4 years ago

It creates three files; two small ones used for autocompletion (one based on Microsoft-hosted data, one based on a file in the plugin repo pending a more authoritative source), and one big one for the SDK downloads (of which there are many; based on official Microsoft data).

To be used by https://github.com/jenkinsci/dotnet-sdk-plugin of which I am the maintainer; plugin changes to use these files are ready and tested.

timja commented 4 years ago

cc @olblak / @daniel-beck

Zastai commented 4 years ago

(ping)

olblak commented 4 years ago

Looks good to me even if I am probably not the best person to review this pull requets on this repository. @halkeye seems to have "recently" committed to this repository

halkeye commented 4 years ago

:P I just upgraded one of the libraries. But I'll try to look through and run a test tomorrow (its 12:30 and bedtime for me) and approve it if it looks fine.

halkeye commented 4 years ago

io.jenkins.plugins.dotnet.data.zip

So it looks fine for me, but my concerns are:

One of the files generated are pulled directly from a plugin - https://raw.githubusercontent.com/jenkinsci/dotnet-sdk-plugin/master/downloadables/tfm-list.json - Its passed through a JSONObject, so I don't see it could be abused or anything but slightly nervious

None of these would be blockers, just "Huh..."

halkeye commented 4 years ago

okay, buckminster, scriptler and recipe both pull directly from github, so i guess its cool \o/

Zastai commented 4 years ago

Yeah, the tfm-list is only used for auto-complete, which does not do any markup AFAIK, so the scope for any issues there seems small. It's just a means of avoiding needing to release a new plugin just because an identifier is added to the list. I have a ticket open with Microsoft to provide a more authoritative file (https://github.com/dotnet/core/issues/4775) but it does not seem extremely likely that will happen soon.