[FIXED JENKINS-62887] Fix for updated Go download page

[orrc]

Ticket: https://issues.jenkins-ci.org/browse/JENKINS-62887

The links provided on the download page no longer provide the absolute URL, so we need to add the prefix ourselves.

I ran the crawler and checked a bunch of the URLs — they looked fine.

[orrc]

Appears to have been caused by this change, FWIW: https://github.com/golang/website/commit/58a31798e86f7e67791de8767e8353f734576199#diff-8dfde61e35bbbe9e94ea52fe96273aa9L280-R280 https://github.com/golang/go/issues/38713

[daniel-beck]

HTTPS 🎉

[continuum-vikrant-tyagi]

Any ETA, for this PR looks, can't we roll back to old URL for time being https://updates.jenkins.io/updates/org.jenkinsci.plugins.golang.GolangInstaller.json

[nishikants]

We ended changing the code in golang-plugin.

In src/main/java/org/jenkinsci/plugins/golang/GolangInstaller.java Line number 62-65. Added the bold text.

**System.out.println("Url: " + installable.url);**

if (expectedPath.installIfNecessaryFrom(
    new URL(**"https://golang.org/" +** installable.url), log, message)) {

Compiled with below command, and copied over the .hpi to ~/.jenkins/plugins/. Before copying moved the earlier golang-plugins files to separate folder.

mvn --batch-mode --show-version --errors -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn --update-snapshots -Dmaven.test.failure.ignore clean install

[orrc]

Any ETA

Whenever someone with commit access has time to review and merge.

We ended changing the code

As alluded to in the Jira ticket, you can edit the .json file to fix the URLs (it's in $JENKINS_HOME/updates). Or just use the existing "Install from .tar.gz" feature of the plugin, and provide the appropriate Go download URL(s) yourself.

[nishikant]

Compiled version of above code is https://github.com/nishikant/golang-plugin/blob/master/golang-1.3-SNAPSHOT.hpi

[daniel-beck]

It is unclear to me whether this should be merged or not. Is the change above expected to be a temporary workaround?

[NotNoah]

It is unclear to me whether this should be merged or not. Is the change above expected to be a temporary workaround?

I think more of a permanent change because the download URLs changed on the Golang site

[orrc]

@daniel-beck This should be merged. You can ignore all the comments; they should have been made on the Jira ticket.