search

jenkins-infra / docker-packaging

This repository contains everything needed to build a docker image used to package jenkins core
MIT License
2 stars 13 forks source link

Don't publish empty releases #47

Closed NotMyFault closed 1 year ago

NotMyFault commented 2 years ago

Hey,

according to the releases tab, new tags are published on a weekly basis.

Is there are particular reason, why releases are published if nothing changed? updatecli keeps filing PRs for those empty changes.

timja commented 2 years ago

I assume it's just rebuilding,

i.e. a number of packages aren't pinned so it's worthwhile to regularly rebuild: https://github.com/jenkins-infra/docker-packaging/blob/d45621aedc978ac1fda46ae2d1cfe045d79be993/Dockerfile#L16-L40

dduportal commented 2 years ago

What @timja said: the goal is to have the "non-pinned" packages to be regularly updated (to benefit from latest security fixes and improvements).

The "empty" message is because release-drafter is usually set up (on the Jenkins infra repositories) to not show any pull requests.

If you are able to update the release-drafter in this repository to print a message instead of "No changes", please share with us how to do it, as it would make the releases more readable.

timja commented 2 years ago

2 second check of the docs @dduportal 😂

https://github.com/release-drafter/release-drafter/

no-changes-template
lemeurherve commented 1 year ago

As release-drafter is correctly filling release notes and as we need these releases to keep unpinned dependencies up to date, I'm closing this issue.