search

jenkins-infra / docs.jenkins.io

Versioned docs of jenkins.io
3 stars 15 forks source link

Fix favicon aspect ratio issue #105

Closed krisstern closed 4 days ago

krisstern commented 1 week ago

Reproduction steps

Go to the tab of docs.jenkins.io to observe the aspect ratio compared to that of https://www.jenkins.io/

Expected Results

Favicon to look like the one in https://www.jenkins.io/

Actual Results

Now our favicon looks kind of fat with a different favicon image

Anything else?

No response

suzitsam commented 1 week ago

I would like to work on this.

SufyaanKhateeb commented 1 week ago

Is this issue taken already? @krisstern

krisstern commented 1 week ago

@SufyaanKhateeb Yes, according to https://github.com/jenkins-infra/docs.jenkins.io/issues/105#issuecomment-2391796679. We usually wait for anyone who has indicated interest for 7 days for a PR before someone else may take the issue and work on it, so you should wait two more days before working on it.

Coffemin commented 5 days ago

It seems like 7 day has passed since @suzitsam has mentioned that he will work on this issue. Can I work on this? @krisstern

krisstern commented 5 days ago

Yes @Coffemin, you are more than welcome to submit a PR for this. But you have 7 days before we open this issue up to another interested contributor.