search

jenkins-infra / docs.jenkins.io

Versioned docs of jenkins.io
3 stars 15 forks source link

fix: specify width of the Blue Ocean image #120

Open Allan2000-Git opened 3 days ago

Allan2000-Git commented 3 days ago

Fixes #61

This PR solves the overlapping image with TOC by providing width to the image

Allan2000-Git commented 3 days ago

@Vandit1604 I went through the code file by file and corrected it. Can you provide the steps to run docs?

krisstern commented 2 days ago

Hi @Allan2000-Git, please refer to https://github.com/jenkins-infra/docs.jenkins.io?tab=readme-ov-file#installing-antora-and-its-prerequisites for instructions on how to run the Antora docs.

krisstern commented 2 days ago

I have reviewed this PR, and it does not seem to fix #61 at all. The following is what I see after the change:

Screenshot 2024-10-12 at 11 20 17 PM

Essentially the side menu now would overlap the Blue Ocean image significantly. For example, I would highly advise using responsive dimensions instead of fixed dimenions in pixels instead, if that route is to be pursued.

Allan2000-Git commented 2 days ago

This approach is not working at all. Please revise or close the PR.

Will make the changes