search

jenkins-infra / github-reusable-workflows

Repository for reusable workflows
MIT License
1 stars 4 forks source link

Test Release Drafter usage on backport branches #14

Open jglick opened 3 years ago

jglick commented 3 years ago

Currently the action assumes that there is a next pseudo-version for Release Drafter. This system likely does not make much sense when backport branches are involved. Should the action detect that it is running on a nondefault branch and just skip the usage of Release Drafter?

jetersen commented 2 years ago

it could assume some things if workflow is not run on main and is manual? So could the shell script, it could use a shared input to target that draft next-branchThatIsNotMain

jglick commented 2 years ago

Or rather than next, just name the draft release according to the base branch, like master or 123.x.

jglick commented 2 years ago

Does not seem to run automatically: unexpected commit from verify-ci-status-action.

Running manually on the backport branch seems to work, including picking the correct PRs for R.D.: https://github.com/jenkinsci/ssh-credentials-plugin/releases/tag/277.280.v1e86b_7d0056b_

It does use the next release name, though only temporarily, so this seems like a race condition (do not try to cut releases from both trunk and a backport branch around the same time).

jetersen commented 2 years ago

It does use the next release name, though only temporarily, so this seems like a race condition (do not try to cut releases from both trunk and a backport branch around the same time).

This seems reasonable, otherwise your asking for trouble? 😅