search

jenkins-infra / github-reusable-workflows

Repository for reusable workflows
MIT License
1 stars 5 forks source link

Make java version an input #5

Closed jetersen closed 2 years ago

jetersen commented 2 years ago

https://github.com/jenkins-infra/github-reusable-workflows/blob/1b4d109fd867c7ae7ae74ce65ffb0c1f0beeb051/.github/workflows/maven-cd.yml#L60

@jglick I think it might be useful to make this a variable or do you think we can transition once and for all? 😆

jglick commented 2 years ago

I think we can just switch to 11. Any reasonably recent plugin should build fine on 11. This action runs no tests so there is no concern about accidentally releasing something broken on 8.

jetersen commented 2 years ago

Since 11 is default on github's virtual environments for ubuntu I think that makes sense.