jenkins-infra / helpdesk

Open your Infrastructure related issues here for the Jenkins project
https://github.com/jenkins-infra/helpdesk/issues/new/choose
16 stars 10 forks source link

[INFRA-138] SCM/JIRA link daemon assumes every repo is in the jenkinsci org #179

Closed jenkins-infra-bot closed 5 years ago

jenkins-infra-bot commented 9 years ago

The Jira spam daemon creates links that always point to jenkinsci, e.g. in comments to INFRA-135, even though the repo is in jenkins-infra.


Originally reported by danielbeck, imported from: SCM/JIRA link daemon assumes every repo is in the jenkinsci org
  • status: Closed
  • priority: Minor
  • resolution: Won't Fix
  • resolved: 2019-02-03T13:00:05+01:00
  • imported: 2022/01/10
jenkins-infra-bot commented 8 years ago

rtyler:

The link daemon appears to be working properly

jenkins-infra-bot commented 8 years ago

danielbeck:

The problem is that it adds the jenkins-ci.org/commit/reponame/… reference, which will always redirect to jenkinsci, to comments on repos not in jenkinsci.

jenkins-infra-bot commented 8 years ago

danielbeck:

Full text of one affected comment:

SCM/JIRA link daemon added a comment - 25/Sep/14 10:27 AM

Code changed in jenkins
User: Oleg Nenashev
Path:
Makefile
http://jenkins-ci.org/commit/ircbot/58fea222c1079a3bb39ddeec5f34dc6cf2d4c735
Log:
INFRA-135 - Fix the build date generation

Signed-off-by: Oleg Nenashev

The compare links (in some comments) work, but the commit links (in every comment) don't.

jenkins-infra-bot commented 8 years ago

rtyler:

D'OH! Thanks for catching this Daniel Beck, in my quest to kill old tickets I didn't fully comprehend what this ticket involved.

jenkins-infra-bot commented 8 years ago

rtyler:

ow ow ow

jenkins-infra-bot commented 8 years ago

rtyler:

Andrew Bayer pointed out that JIRA can link directly to GitHub nowadays. So this is an option to nuke the SCM Link daemon entirely.

The only downside to it is that it is requesting OAuth permissions to read all my repositories, which I'm definitely not granting

jenkins-infra-bot commented 5 years ago

danielbeck:

This bot is obsolete.

jenkins-infra-bot commented 2 years ago

[Is related to: INFRA-881]

jenkins-infra-bot commented 2 years ago

[Is related to: INFRA-323]