jgit cloning not converting line ends on windows?

[jtnord]

Service(s)

ci.jenkins.io

Summary

https://github.com/jenkinsci/google-oauth-plugin/pull/209/ fails in CI on windows as it appears all the files have UNIX line endings.

https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgoogle-oauth-plugin/detail/PR-209/1/pipeline/79/#step-98-log-14 appears to show that the clone/fetch of the project is done by jgit and not git. this could be a case of a) misreporting by sportless (but it affects 50 files which is every single java file in src/main) b) spotless is not pickup up where the global/system config should be and is assuming they should be \n and are \r\n (they have been converted) c) jgit is not pickup up where the global/system config should be and not converting the files d) the option is not configured - so there is no conversion and spotless falls back to expecting native line end. e) something is very messed up in the project (but it works locally on windows). f) jgit plugin ignores settings from the agent and need to be specified in code.

without some access to the node it is not possible to diagnose for a plugin developer what is wrong here, but it seems to not be completely widespread.

Reproduction steps

No response

[jtnord]

was worked around by switching to container agents - so this could be something specific to the VMs (in Azure?)

[dduportal]

was worked around by switching to container agents - so this could be something specific to the VMs (in Azure?)

Thanks for the pointer (sorry for the delay, today was really busy for the whole team).

It make sense as we have not (yet) unified Windows VM and container images:

• Container images are "classic" Dockerfiles defined in https://github.com/jenkins-infra/docker-inbound-agents/tree/main/maven. Git installation comes from the parent (official) image here: https://github.com/jenkinsci/docker-agent/blob/9b2565224e465060a541fb30269948a4983b253a/windows/nanoserver/Dockerfile#L47-L56
  • Built on top of nanoserver
• While VM are defined in https://github.com/jenkins-infra/packer-images. Git installation is defined here: https://github.com/jenkins-infra/packer-images/blob/1b0f119e8458058cf7dc1dde0c2ef667fe892b77/provisioning/windows-provision.ps1#L133-L144 -Built on top of Windows Server Core

@jtnord I do not know which setting to look for: I guess since it is jgit it could be a general Windows setting, a git (installlation) setting or even a Java setting?

[jonesbusy]

Similar issue here : https://ci.jenkins.io/job/Plugins/job/locale-plugin/job/main/83/console after I formatted the plugin and updated Jenkinsfile

Was a mistake to build on VM. Fixed by using useContainerAgent: true.

So behavior is definitely not the same between Windows VM and container agent