Label for internal changes which nonetheless merit a release

jenkins-infra / interesting-category-action

Validate that the next draft release is interesting

MIT License

1 stars 3 forks source link

Label for internal changes which nonetheless merit a release #3

Closed jglick closed 2 years ago

jglick commented 2 years ago

There are a fair number of cases like https://github.com/jenkinsci/support-core-plugin/pull/360 where a PR is not terribly interesting from a user perspective—some dependency bumps, POM wrangling—yet we need a release anyway, in order to feed into jenkinsci/bom or other dependencies or tooling. There should be a label (and I guess RD category) for this purpose, which should be displayed in an unexciting section of release notes yet still be considered interesting by this action.

Workarounds:

use bug or enhancement and risk confusing end users
merge, wait for trunk CI to be green (which could take up to an hour), then manually trigger the CD action

jetersen commented 2 years ago

We could use developer? As the change applies to plugin developers anyhow 😄 https://github.com/jenkinsci/.github/blob/ddd4660711fd559b0fc4696747b81546297485c2/.github/release-drafter.yml#L38-L40

So a use case would be Dependabot marks it dependency by default, but if we have something interesting for plugin developers in jenkinsci/bom we could use the developer label

jetersen commented 2 years ago

It is already setup to work with developer: 👷 https://github.com/jenkins-infra/interesting-category-action/blob/1a2c10ae989cba9b76a95e0f0364aaf4f9642218/action.yaml#L13

jglick commented 2 years ago

Probably close enough, yes.

jetersen commented 2 years ago

Created the label in jenkinsci/bom feel free to change the color:

jetersen commented 2 years ago

FYI @basil @timja related to jenkinsci/bom release

Of course could be relevant for others when we go around bumping BOM and POM to suggest that they use the label developer when using CD or release drafter.