search

jenkins-infra / ircbot

Jenkins IRCbot
https://jenkins.io/projects/infrastructure/ircbot/
MIT License
23 stars 27 forks source link

[INFRA-146] - Move all configurations to a customizable IrcBotConfig #17

Closed oleg-nenashev closed 10 years ago

oleg-nenashev commented 10 years ago

This PR is a slight overkill for INFRA-146, but such generalization could be useful for future testing purposes or "#jenkins-infra-admin"

Signed-off-by: Oleg Nenashev o.v.nenashev@gmail.com

oleg-nenashev commented 10 years ago

@rtyler, will it work for your case?

rtyler commented 10 years ago

@oleg-nenashev it will probably work but what I don't see is the format for the configuration file in this pull request

oleg-nenashev commented 10 years ago

You can configure them using System properties. :https://wiki.jenkins-ci.org/display/JENKINS/Features+controlled+by+system+properties

Example: -Dircbot.name=jenkins-admin-test

oleg-nenashev commented 10 years ago

@orrc , thanks for comments, I've fixed the most of issues in parallel. I should wake up before coding next time :(

Regarding tests, it makes sense to implement more test suites. The current implementation just tests that there's no errors in static vars initialization.

oleg-nenashev commented 10 years ago

@rtyler , @orrc I want to merge this version. It works well for testing purposes. Do you agree?

kohsuke commented 10 years ago

+1

oleg-nenashev commented 10 years ago

I succesfully tested the bot from #19. It also includes this PR. I think it can be deployed to the production, but it makes sense to discuss config locations before.

oleg-nenashev commented 10 years ago

Going forward with the IRC Bot. If something appears, let's modify the tree in the trunk