search

jenkins-infra / ircbot

Jenkins IRCbot
https://jenkins.io/projects/infrastructure/ircbot/
MIT License
23 stars 27 forks source link

Disable service hook creation #62

Closed slide closed 6 years ago

slide commented 6 years ago

See http://lists.jenkins-ci.org/pipermail/jenkins-infra/2018-October/001576.html

slide commented 6 years ago

I kept it in so that if something needs to be added in the future, we can see where it was. I can definitely just remove it though.

daniel-beck commented 6 years ago

That's what the Git history is for.

slide commented 6 years ago

I know, I tell people at work that all the time and then fell for it myself. I feel so ashamed. ;-)

daniel-beck commented 6 years ago

Next step: Someone squashes this 😆

slide commented 6 years ago

You can squash while merging

rtyler commented 6 years ago

Squashing because I live to make @daniel-beck happy