jenkins-infra / jenkins-io-components

https://jenkins-io-components.netlify.app
MIT License
4 stars 25 forks source link

feat: Add hover effect to Navbar links #145

Open Ratul-Saha-003 opened 7 months ago

Ratul-Saha-003 commented 7 months ago

Added hover effect to Navbar links. Before: Screenshot from 2024-03-17 19-20-39

After: Screenshot from 2024-03-17 19-23-05

This Pull Request resolves issue #144

Ratul-Saha-003 commented 7 months ago

@halkeye The PR was incomplete. It is complete now. I can't understand the reason for this linting error.

halkeye commented 7 months ago
<file name="/home/jenkins/agent/workspace/tes_jenkins-io-components_PR-145/src/jio-navbar.css">
 <error source="stylelint.rules.rule-empty-line-before" line="107" column="1" severity="error" message="Expected empty line before rule (rule-empty-line-before)" />

does line 107 on jio-navbar.css have a empty line before the next rule?

Ratul-Saha-003 commented 7 months ago
<file name="/home/jenkins/agent/workspace/tes_jenkins-io-components_PR-145/src/jio-navbar.css">
 <error source="stylelint.rules.rule-empty-line-before" line="107" column="1" severity="error" message="Expected empty line before rule (rule-empty-line-before)" />

does line 107 on jio-navbar.css have a empty line before the next rule?

@halkeye Made the appropriate changes.

halkeye commented 7 months ago

I'll admit, i'm not sure why a hover effect is wanted. Have you talked to any of the sig leaders about it? like @MarkEWaite or @kmartens27 ?

Ratul-Saha-003 commented 7 months ago

No, but I was working with the Navbar component when I noticed that it is very easy to click another link when there is no difference on hover.