jenkins-infra / jenkins-io-components

https://jenkins-io-components.netlify.app
MIT License
4 stars 25 forks source link

feat: Added 'Security' as a tab #56

Closed Vandit1604 closed 1 year ago

Vandit1604 commented 1 year ago

closes https://github.com/jenkins-infra/jenkins.io/issues/5877 in jenkins.io

halkeye commented 1 year ago

So CI is still broken for a day or two (infra is working on the last bits needed), but overall it sounds like an improvement. I'll ping kevin when the preview sites are working

halkeye commented 1 year ago

Also, right now we are using semantic release, so commit messages need to have fix: or feat: or chore: type thing. Can you update your commit message to feat: added security as a tab. I think i can do it on merge, but its easier if you do it in the PR

Vandit1604 commented 1 year ago

Also, right now we are using semantic release, so commit messages need to have fix: or feat: or chore: type thing. Can you update your commit message to feat: added security as a tab. I think i can do it on merge, but its easier if you do it in the PR

I'll do it now. I'll correct it

halkeye commented 1 year ago

https://deploy-preview-56--jenkins-io-components.netlify.app/?path=/story/example-navbar--all-links-external

@kmartens27 @MarkEWaite

halkeye commented 1 year ago

Awesome. I'll merge as soon as releasing is fixed on infra.ci

halkeye commented 1 year ago

🤞

jenkins-io-components[bot] commented 1 year ago

:tada: This PR is included in version 1.17.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

halkeye commented 1 year ago

So https://cdn.jsdelivr.net caches for 6 hours, and then tells the browser to cache for 20 hours, so you should see changes go live with a hard refresh after 6 hours.

This is exciting, down with github actions!