search

jenkins-infra / jenkins-io-components

https://jenkins-io-components.netlify.app
MIT License
4 stars 25 forks source link

feat: Added `Books` hyperlink in `Resource` section of `Footer` #71

Closed shashanksah143 closed 1 year ago

shashanksah143 commented 1 year ago

Related to the additional content on the books page added by https://github.com/jenkins-infra/jenkins.io/pull/6043

NotMyFault commented 1 year ago

Do we really need a dedicated footer entry for this? Feels a bit redundant to me, especially when this is shown on other pages than jenkins.io

shashanksah143 commented 1 year ago

Hi @NotMyFault , I made the changes suggested by Kris Stern. Please refer this issue for more details: https://github.com/jenkins-infra/jenkins.io/issues/6019 Jenkins.io have a traffic of around 1 Million page visit per month. So I thought it will be good to add books page in the resource section of footer as I didn't able to find any web page in jenkins.io which will redirect me to books page.

krisstern commented 1 year ago

Originally the link to the books section was on a dropdown in the header, but that got removed along the line. So it would be good to show it somewhere visible to the public, and not hidden as currently is now.

krisstern commented 1 year ago

The change looks good in the preview for the UI BTW.

halkeye commented 1 year ago

Personally I don't think books is important enough to be visible on every page, but at the very least lets wait till the new content is merged. Right now linking to a page with 2 books from 5-10 years ago isn't really great optics.

krisstern commented 1 year ago

Yeah, I see where you are coming from

shashanksah143 commented 1 year ago

Do we have any updates for this PR? The books page has been updated. Currently, it has 6 books.

NotMyFault commented 1 year ago

Do we have any updates for this PR? The books page has been updated. Currently, it has 6 books.

My concerns and Gavin's comments remain unacknowledged. If there is no convincing and logical reasoning, why books deserve a separate entry in the footer, this PR can't proceed.

The footer already contains 23 links to various top-class pages. I don't think the book's page is relevant enough for *.jenkins.io visitors to deserve a separate footer entry. You can use the search bar to find the books page, if you are interested in books about Jenkins.

shashanksah143 commented 1 year ago

Do we have any updates for this PR? The books page has been updated. Currently, it has 6 books.

My concerns and Gavin's comments remain unacknowledged. If there is no convincing and logical reasoning, why books deserve a separate entry in the footer, this PR can't proceed.

The footer already contains 23 links to various top-class pages. I don't think the book's page is relevant enough for *.jenkins.io visitors to deserve a separate footer entry. You can use the search bar to find the books page if you are interested in books about Jenkins.

On the current website, there are only two ways to reach the book page, 1> By searching it inalgolia search 2> By changing the URL manually to /books

And because of that, the books page will not be easily accessible to the users. If the footer is not a good place to put it. Then we can put it in the navbar, but for that, I will need your guidance on which section of the navbar we should put it. I am also open to suggestion for any other place where we can put it.

MarkEWaite commented 1 year ago

We discussed in Docs Office Hours (Asia) and felt that we should add "Books" to the end of the "Documentation" drop down menu and that we should save vertical space in the drop down by removing the "Tutorial" submenus ("Guided Tour" and "Other tutorials"). The tutorial has "Guided Tour as its first segment and then the other tutorials are the later segments on the same page.

No problem for us that it is not in the footer.

shashanksah143 commented 1 year ago

We discussed in Docs Office Hours (Asia) and felt that we should add "Books" to the end of the "Documentation" drop down menu and that we should save vertical space in the drop down by removing the "Tutorial" submenus ("Guided Tour" and "Other tutorials"). The tutorial has "Guided Tour as its first segment and then the other tutorials are the later segments on the same page.

No problem for us that it is not in the footer.

Thank you for your suggestion. I will make the necessary changes in the navbar.

shashanksah143 commented 1 year ago

Created a new issue and its corresponding PR to address changes discussed here. So, closing the PR.

Thank you everyone for your support and guidance.