Closed shashanksah143 closed 1 year ago
Works for me, but why does this PR attempt to remove tutorial links?
@MarkEWaite mentioned in the comment, that these two sub-sections should be removed from the dropdown. Please refer this https://github.com/jenkins-infra/jenkins-io-components/pull/71#issuecomment-1473083640
Works for me, but why does this PR attempt to remove tutorial links?
@MarkEWaite mentioned in the comment, that these two sub-sections should be removed from the dropdown. Please refer this #71 (comment)
It would be better to do this removal in a separate pull request.
Works for me, but why does this PR attempt to remove tutorial links?
@MarkEWaite mentioned in the comment, that these two sub-sections should be removed from the dropdown. Please refer this #71 (comment)
It would be better to do this removal in a separate pull request.
Okay, I will create a different PR for that.
It would be better to do this removal in a separate pull request.
I'm fine with a separate pull request. When I suggested that the tutorial entries be simplified the same operation as the addition, it was intended to avoid lengthening that already rather long dropdown menu. However, it is not the longest menu in the list of menus, so two pull requests will make it easier to understand the changes.
Hi @NotMyFault, I have created a different PR for removing the sub-sections of the tutorials. PR https://github.com/jenkins-infra/jenkins-io-components/pull/81 And this PR has the changes for adding a book link in the navbar.
:tada: This PR is included in version 1.20.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Hi @NotMyFault, can you please review this PR? This PR is for the Issue #78