search

jenkins-infra / jenkins-maven-cd-action

1 stars 7 forks source link

Recognize localization as trigger #20

Closed NotMyFault closed 2 years ago

NotMyFault commented 2 years ago

Depends on https://github.com/jenkinsci/.github/pull/81

NotMyFault commented 2 years ago

@timja any plans how we want to proceed with this PR? This label would be the one I'd add to the default workflow.

jglick commented 2 years ago

@timja do you recall if this configuration is even still used? https://github.com/jenkins-infra/interesting-category-action/pull/4 is the relevant spot, I thought. In which case https://github.com/jenkins-infra/jenkins-maven-cd-action/blob/a0a2c865bf13c0937b93d3190ed128af1bab2947/run.sh#L3-L6 and https://github.com/jenkins-infra/jenkins-maven-cd-action/blob/a0a2c865bf13c0937b93d3190ed128af1bab2947/action.yaml#L10-L16 could be deleted and https://github.com/jenkins-infra/jenkins-maven-cd-action/blob/a0a2c865bf13c0937b93d3190ed128af1bab2947/action.yaml#L20 amended? Or did you leave this clause for compatibility after introducing interesting-category-action?

timja commented 2 years ago

I think it was for compatibility can't remember where the discussion at the time was though.