search

jenkins-infra / jenkins-maven-cd-action

1 stars 7 forks source link

use modern syntax for altDeploymentLocation #27

Open jtnord opened 1 year ago

jtnord commented 1 year ago

when performing a CD release the build produces warnings about old formats for altDeploymentLocation

[INFO] --- maven-deploy-plugin:3.1.1:deploy (default-deploy) @ aws-java-sdk-parent ---
[INFO] Using alternate deployment repository maven.jenkins-ci.org::default::https://repo.jenkins-ci.org/releases/
[WARNING] Using legacy syntax for alternative repository. Use "maven.jenkins-ci.org::https://repo.jenkins-ci.org/releases/" instead.

This requires maven 3 (as noted by https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html#altDeploymentRepository) - and there should IIUC be no need to support maven 2.

Note: In version 2.x, the format was id::layout::url where layout could be default (ie. Maven 2) or legacy (ie. Maven 1), but since 3.0.0 the layout part has been removed because Maven 3 only supports Maven 2 repository layout.

Note: this is completely untested but should fix #24

lemeurherve commented 1 year ago

@jtnord should someone review this PR?

LGTM but not really knowledgeable on the subject.

jtnord commented 1 year ago

@jtnord should someone review this PR?

LGTM but not really knowledgeable on the subject.

Probably should, or you could YOLO :-)

jglick commented 1 year ago

Should ideally be pretested in https://github.com/jenkinsci/jenkins-infra-test-plugin; I can try to do that if you do not feel up to it.