search

jenkins-infra / jenkins-security-scan

GitHub Workflow and Action for the Jenkins Security Scan
MIT License
1 stars 6 forks source link

Update codeql-action to v2 #10

Closed offa closed 1 year ago

offa commented 2 years ago

Update to v2 as v1 will be deprecated in December 2022.

closes #9

offa commented 2 years ago

/reviewer @daniel-beck

offa commented 2 years ago

+1 from me, though I've not tested it and am not sure how I would test it.

Change this line:

uses: jenkins-infra/jenkins-security-scan/.github/workflows/jenkins-security-scan.yaml@v2

to the PR branch:

uses: offa/jenkins-security-scan/.github/workflows/jenkins-security-scan.yaml@v2_update
#     ^^^^                                                                    ^^^^^^^^^

The warning shouldn't appear anymore.

MarkEWaite commented 2 years ago

The warning shouldn't appear anymore.

Confirmed with two repositories (elastic-axis and implied-labels) that the warning no longer appears with the change and that there are no new warnings as a result of the change.

offa commented 2 years ago

:warning: @MarkEWaite Please remember to change back to the previous settings once this PR has been merged.

daniel-beck commented 1 year ago

Thanks! Merged and updated https://github.com/jenkins-infra/jenkins-security-scan/releases/tag/v2 👍