Parameterized Java version inconsistent with CD workflow

jenkins-infra / jenkins-security-scan

GitHub Workflow and Action for the Jenkins Security Scan

MIT License

1 stars 6 forks source link

Parameterized Java version inconsistent with CD workflow #29

Closed basil closed 4 months ago

basil commented 5 months ago

In https://github.com/jenkins-infra/github-reusable-workflows/pull/31 it was discussed whether to make the Java version a parameter or to just use a modern version as an internal implementation detail, with a decided preference for the latter. This repository's choice of a parameterized value is inconsistent with that decision.

daniel-beck commented 5 months ago

Would #30 address this request? Or is the request to remove the ability to specify the version entirely?

basil commented 5 months ago

I meant inconsistent on an API level. Inconsisency on an implementation level is far less important.