search

jenkins-infra / jenkins.io

A static site for the Jenkins automation server
https://jenkins.io
Other
317 stars 1.2k forks source link

`make check` doesn't work on Mac OS #6038

Closed daniel-beck closed 1 year ago

daniel-beck commented 1 year ago

I wanted to run make check manually on locally prepared security advisory content to prevent CI breakages after direct pushes of the advisory, but was surprised to find it hard-codes Linux x86_64 executables:

$ make check
scripts/check-hard-coded-URL-references
curl -qsL https://github.com/crate-ci/typos/releases/download/v1.13.4/typos-v1.13.4-x86_64-unknown-linux-musl.tar.gz | tar xvzf - ./typos
x ./typos
curl -qsL https://github.com/halkeye/typos-json-to-checkstyle/releases/download/v0.1.1/typos-checkstyle-v0.1.1-x86_64 > typos-checkstyle && chmod 0755 typos-checkstyle
./typos --format json | ./typos-checkstyle - > checkstyle.xml || true
/bin/sh: ./typos: cannot execute binary file
/bin/sh: ./typos-checkstyle: cannot execute binary file

Possible Solution

More Docker?

dduportal commented 1 year ago

I'm interested in fixing this :)

daniel-beck commented 1 year ago

CI broken after advisory again: https://github.com/jenkins-infra/jenkins.io/pull/6174

daniel-beck commented 1 year ago

Fix attempt in https://github.com/jenkins-infra/jenkins.io/pull/6175, please test :)

dduportal commented 1 year ago

Oh, I forgot to open my PR weeks ago. Your PR is clearly better : let's go for it!

daniel-beck commented 1 year ago

FTR first result https://github.com/jenkins-infra/jenkins.io/commit/0e6335ca3b1702e3842383b520e0e0921165dc25#diff-f4eaaba6f80f920c13375550e7c86add0532f1cbc10516f037a8edd8bdf7cce7