jenkins-infra / jenkins.io

A static site for the Jenkins automation server
https://jenkins.io
Other
320 stars 1.22k forks source link

Add a page explaining how to change the default "notification" URL interface #6137

Open lemeurherve opened 1 year ago

lemeurherve commented 1 year ago

Describe your use-case which is not covered by existing documentation.

There doesn't seem to be any page on jenkins.io explaining how to change the default "notification" URL interface to use the Classic UI or the Pipeline Graph View plugin for example instead of Blue Ocean.

Noticed via https://github.com/jenkinsci/pipeline-graph-view-plugin/issues/245

Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.

The only reference I found is https://docs.cloudbees.com/docs/cloudbees-ci-kb/latest/client-and-managed-masters/how-to-point-notification-links-to-classic-jenkins-path-rather-than-to-blueocean-endpoint

KalleOlaviNiemitalo commented 1 year ago

Currently, the system property or environment variable somewhat overrides per-user settings. See https://github.com/jenkins-infra/helpdesk/issues/2833#issuecomment-1120933932 and JENKINS-69006.

lemeurherve commented 1 year ago

I knew I forgot something, thanks for the reminder @KalleOlaviNiemitalo!

About this issue, getting a page explaining how users can set their prefered viewer would be nice already.

Regarding JENKINS-69006 I saw you've already found where the regression came, do you mind if I try to implement the fix you've proposed in https://issues.jenkins.io/browse/JENKINS-69006?focusedCommentId=428019, with you as co-author of course?

KalleOlaviNiemitalo commented 1 year ago

I actually started working on it last weekend, at https://github.com/KalleOlaviNiemitalo/display-url-api-plugin/compare/master...defer-config; but I referenced the wrong Jira issue and did not update tests yet. If you can spend the time to fix the issue, that's great.

dwnusbaum commented 1 year ago

For what it's worth, I just fixed JENKINS-69006 in display-url-api 2.3.9, and I added a global configuration page to configure a default provider as well (JENKINS-43205) so that users don't need to set environment variables/system properties unless they really want to. See https://github.com/jenkinsci/display-url-api-plugin/pull/202.

I also updated pipeline-graph-view to activate automatically by default if no preference is configured (matches the behavior of blueocean-display-url), see https://github.com/jenkinsci/pipeline-graph-view-plugin/pull/29.