Add jenkins-infra tools

[dduportal]

The jenkins infrastructure requires additional tools that should be installed in these templates:

• [x] The jx-release-version because of https://github.com/jenkins-infra/pipeline-library/blob/544d04d1dbc67cbe7aed681924c44488bb00b6b6/vars/buildDockerAndPublishImage.groovy#L63-L74
• [x] The gh CLI because of https://github.com/jenkins-infra/pipeline-library/blob/master/vars/buildDockerAndPublishImage.groovy#L178-L189
• [x] The container-structure-test tool because of https://github.com/jenkins-infra/pipeline-library/blob/master/vars/buildDockerAndPublishImage.groovy#L110-L129 ~- [ ] The 'uc` and jenkins-version CLIs because of https://github.com/jenkins-infra/docker-jenkins-weekly and https://github.com/jenkins-infra/docker-jenkins-lts~ (removed from initial list as we favor using the jenkins-plugin-cli instead)
• [x] The updatecli because... well... jenkins infra uses it everywhere - https://github.com/jenkins-infra/packer-images/pull/398
• [x] The hadolint tool because of https://github.com/jenkins-infra/pipeline-library/blob/544d04d1dbc67cbe7aed681924c44488bb00b6b6/vars/buildDockerAndPublishImage.groovy
• [x] The 'netlify-golang-deploy` CLI by @halkeye because of https://github.com/jenkins-infra/plugin-site/blob/0df7d8e482ba9bc38492a324f6d1f64c2daa4b6d/Jenkinsfile_k8s#L183, https://github.com/jenkins-infra/jenkins-is-the-way/blob/ba65a589f7a44de2d542026852f22d99dd62eeed/Jenkinsfile_k8s#L155 and https://github.com/jenkins-infra/jenkins.io/blob/65ab9b3afea35bcef7128a229e6f1a34158223f1/Jenkinsfile_k8s#L122 => https://github.com/jenkins-infra/packer-images/pull/404
• [x] The asdf tool because of https://github.com/jenkins-infra/jenkins.io/blob/65ab9b3afea35bcef7128a229e6f1a34158223f1/Jenkinsfile_k8s#L122 and to provide additional values to users (any tool could be quickly installed on the go)
  • For instance: nodejs and golang are used quite extensively
  • [x] Ruby + bundler - https://github.com/jenkins-infra/jenkins-infra/issues/2247
• The hashicorp tools because https://github.com/jenkins-infra/packer-images/blob/main/Jenkinsfile_k8s and (https://github.com/jenkins-infra/aws, https://github.com/jenkins-infra/datadog, https://github.com/jenkins-infra/azure, etc.)
  • [x] terraform - https://github.com/jenkins-infra/packer-images/pull/411
  • [x] packer - https://github.com/jenkins-infra/packer-images/pull/309
  • [x] vagrant - https://github.com/jenkins-infra/jenkins-infra/issues/2248
• [x] The cloud CLIs because ... well... we use these clouds
  • [x] awscli - https://github.com/jenkins-infra/packer-images/pull/402
  • [x] az (Azure CLI)
  • [x] doctl - https://github.com/jenkins-infra/packer-images/pull/950
• The terraform-related tools because https://github.com/jenkins-infra/pipeline-library/blob/master/vars/terraform.groovy
  • [x] #360
  • ~[ ] infracost~ (as per https://github.com/jenkins-infra/packer-images/pull/393)
• Useful CLIs:
  • [x] jq - https://github.com/jenkins-infra/packer-images/pull/216
  • [x] yq - https://github.com/jenkins-infra/packer-images/pull/277
  • [x] xq - https://github.com/jenkins-infra/packer-images/pull/958
• Kubernetes Management utilities (as per https://github.com/jenkins-infra/docker-helmfile/blob/main/Dockerfile):
  • [x] kubectl
  • [x] helm
  • [x] helmfile
  • [x] sops
  • [x] helm-plugins (https://github.com/jenkins-infra/docker-helmfile/blob/main/Dockerfile#L85-L91)
• [ ] NodeJS (LTS)
  • [x] Linux - https://github.com/jenkins-infra/packer-images/pull/468
  • [ ] Windows
• [ ] yamllint as in https://github.com/jenkins-infra/docker-helmfile/blob/c51fa35103632cb6c026d101ef5bf69060d265f5/Dockerfile#L23C3-L23C11
  • [x] Linux - https://github.com/jenkins-infra/packer-images/pull/970
  • ~[ ] Goss-Linux~ not version tracked
  • [ ] Windows
  • [ ] Goss-windows
• [ ] Golang
  • [ ] Linux - https://github.com/jenkins-infra/packer-images/pull/981
  • [ ] Goss-Linux - https://github.com/jenkins-infra/packer-images/pull/982
  • [ ] Windows
  • [ ] Goss-windows

[lemeurherve]

• [x] Docker buildx because we want to build multi architectures images

[dduportal]

• [x] jq on Windows

[dduportal]

First batch: https://github.com/jenkins-infra/packer-images/pull/216

[lemeurherve]

• [x] packer
• [x] docker (?)

WDYT about using Chocolatey to install most of them if available?

[dduportal]

WDYT about using Chocolatey to install most of them if available?

If the version can be specified: yes (would be most usefull). Otherwise nope.

[lemeurherve]

If the version can be specified: yes

Yes: https://docs.chocolatey.org/en-us/choco/commands/install#examples

Docker buildx should already be included with Docker (needs Docker for Desktop for Windows though):

[dduportal]

Docker buildx should already be included with Docker (needs Docker for Desktop for Windows though):

About this:

• Installing buildx, can be done manually as per https://github.com/docker/buildx#manual-download (binary from their GitHub releases) as an alternative to Docker Desktop.
• Docker Desktop could be an option, but:
  • The Linux version uses a VM so we can't use it (nested virtualization not available on all cloud VMs), so no feature parity Linux <-> Windows
  • The Windows version should be (I assume chocolatey allows it) setup to use Windows containers instead of the default Linux containers (otherwise it make no sense for us to spawn Windows VMs to run Linux containers 😅)
  • Not sure about the licensing. I assume we need to get a license, so it means authenticating a Docker account to enable it per installation: not really hand.

Given that we use Windows container on Windows VMs, and that buildx is not supported for windows container, WDYT about only adding buildx on linux templates (+add a comment on the tools version YAML explaining why it's not supported) ?

[dduportal]

Adding NodeJS (ref. https://github.com/jenkins-infra/packer-images/pull/468, #475 and #476)

[smerle33]

not sure we need to install oniguruma as per https://github.com/jenkins-infra/docker-hashicorp-tools/blob/fe538ce08d4ccc8e2d86df0f730b12bea4d097e1/Dockerfile#L25C1-L26C14

no occurrence of onigin jenkins-infra

[lemeurherve]

• [ ] Docker buildx because we want to build multi architectures images

Done in #1215

Given that we use Windows container on Windows VMs, and that buildx is not supported for windows container, WDYT about only adding buildx on linux templates (+add a comment on the tools version YAML explaining why it's not supported) ?

Now supported, see PR for ref 🙂

[dduportal]

Now supported, see PR for ref 🙂

Only on client side :) But still useful as per your PR