search

jenkins-infra / packer-images

This repository hosts the packer definitions for the Jenkins Infrastructure
MIT License
17 stars 18 forks source link

`make install` not exiting when fail #337

Open smerle33 opened 1 year ago

smerle33 commented 1 year ago

as per https://infra.ci.jenkins.io/blue/organizations/jenkins/infra-tools%2Fpacker-images/detail/0.41.1/1/pipeline/249#step-306-log-261 the installation of make is not aborting the build when it fail.

smerle33 commented 1 year ago

this as for consequence to generate an error in the deleting process on azure-arm and windows VM probably due to a delay in stopping the machine.

dduportal commented 1 year ago

As per https://github.com/jenkins-infra/packer-images/pull/459#issuecomment-1375865100 and https://ss64.com/ps/call.html, the ampersand (&) character runs the provided instruction as a background job, so the exit code is not captured.

Worth a PR to run the sanity check on a subsequent powershell provider AFTER running the windows-provision.ps1 provider.