jenkins-infra / pipeline-library

Collection of custom steps and variables for our Jenkins instance(s)
295 stars 136 forks source link

fix(infra) add support for internal ACPs #859

Closed dduportal closed 6 months ago

dduportal commented 6 months ago

Related to https://github.com/jenkins-infra/helpdesk/issues/3954#issuecomment-2114950444

This PR is a medium-term fix to ensure the new "internal" (without public ingress) ACP (in the ci.jenkins.io-agents-1 AKS cluster) can be used without failing the healthcheck.

Notes:

dduportal commented 6 months ago

Currently testing in https://github.com/jenkinsci/jenkins-infra-test-plugin/pull/126

dduportal commented 6 months ago

External test in https://github.com/jenkinsci/jenkins-infra-test-plugin/pull/126 worked as expected:

9:24:03  + curl --fail --silent --show-error --location http://artifact-caching-proxy.artifact-caching-proxy:8080/health
19:24:03  OK
19:24:04  INFO: using artifact caching proxy from 'azure-aks-internal' provider.

and tested with an existing one (to ensure no regression):

19:31:41  + curl --fail --silent --show-error --location https://repo.aws.jenkins.io/health
19:31:41  OK
19:31:41  INFO: using artifact caching proxy from 'aws' provider.

=> Self merging