search

jenkins-infra / plugin-health-scoring

This project aims to introduce a metric system to calculate the health score of each plugin within the Jenkins ecosystem and reflect the final scores on the Plugin Site for the plugin maintainers and users.
https://plugin-health.jenkins.io
MIT License
24 stars 46 forks source link

Setup spotless #477

Closed alecharp closed 8 months ago

alecharp commented 8 months ago

Description

Checkstyle on its own did not notice the missing license header on a couple of classes.

Testing done

There is no code modification.

### Submitter checklist
- [ ] If an issue exists, it is well described and linked in the description
- [x] The description of this pull request is detailed and explain why this pull request is needed
- [x] The changeset is on a specific branch. Using `feature/` for new feature, or improvements ; Using `fix/` for bug fixes ; Using `docs/` for any documentation changes.
- [ ] If required, the documentation has been updated
- [x] There is automated tests to cover the code change / addition or an explanation why there is no tests in the description.
Jagrutiti commented 8 months ago

The changes look good to me.

In the PR description you have mentioned that checkstyle ignored the missing license header.

Would spotless solve the issue?

alecharp commented 8 months ago

That's what this PR is for.