jenkins-infra / plugin-health-scoring

This project aims to introduce a metric system to calculate the health score of each plugin within the Jenkins ecosystem and reflect the final scores on the Plugin Site for the plugin maintainers and users.
https://plugin-health.jenkins.io
MIT License
24 stars 46 forks source link

Inheriting contributing guide should not lower score #494

Closed alecharp closed 8 months ago

alecharp commented 8 months ago

Description

Closes #487.

This addresses the feedback that inheriting from the global plugin contributing guide shouldn't be a bad thing for the plugin. Only a few plugins have specific build / contributing requirements. It will be hard / impossible to have a specific behavior to detect those, but we can accept guideline inheritance, reward specific guideline and warn about empty ones.

Testing done

Adding unit tests on probe and tweaking tests on scoring

### Submitter checklist
- [x] If an issue exists, it is well described and linked in the description
- [x] The description of this pull request is detailed and explain why this pull request is needed
- [x] The changeset is on a specific branch. Using `feature/` for new feature, or improvements ; Using `fix/` for bug fixes ; Using `docs/` for any documentation changes.
- [ ] If required, the documentation has been updated
- [x] There is automated tests to cover the code change / addition or an explanation why there is no tests in the description.