search

jenkins-infra / plugin-health-scoring

This project aims to introduce a metric system to calculate the health score of each plugin within the Jenkins ecosystem and reflect the final scores on the Plugin Site for the plugin maintainers and users.
https://plugin-health.jenkins.io
MIT License
24 stars 46 forks source link

Fix Maven options interpretation during CI build #496

Closed lemeurherve closed 7 months ago

lemeurherve commented 8 months ago

Description

This PR fixes tags publication by actually passing OPTS as env var to maven script.

Fixup of:

Testing done

Successful replay of the 3.8.0 tag on infra;ci.jenkins.io

### Submitter checklist
- [x] If an issue exists, it is well described and linked in the description
- [x] The description of this pull request is detailed and explain why this pull request is needed
- [x] The changeset is on a specific branch. Using `feature/` for new feature, or improvements ; Using `fix/` for bug fixes ; Using `docs/` for any documentation changes.
- [ ] If required, the documentation has been updated
- [ ] There is automated tests to cover the code change / addition or an explanation why there is no tests in the description.
alecharp commented 7 months ago

I'm surprise this is necessary as the previous release replay (3.7.1) was successful..

lemeurherve commented 7 months ago

I'm surprise this is necessary as the previous release replay (3.7.1) was successful..

The replay wasn't exactly the same (my mistake, sorry), it was still using """ instead of ''' thus $OPTS was interpolated by Groovy.

Using ''' is safer.