search

jenkins-infra / plugin-modernizer-tool

MIT License
9 stars 8 forks source link

UpgradeToJava17 recipe fails for the javadoc and git-client plugin #260

Open gounthar opened 2 months ago

gounthar commented 2 months ago

Jenkins and plugins versions report

Gitpod

What Operating System are you using (both controller, and any agents involved in the problem)?

Gitpod

Reproduction steps

 java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar --dry-run --plugins git-client --recipes UpgradeToJava17 --export-datatables
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=1
Starting Plugin Modernizer 
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=1
Skipping forking plugin git-client in dry-run mode 
Skipping sync plugin git-client in dry-run mode 
Fetching plugin code locally git-client... 
Collecting metadata for plugin git-client... Please be patient 
Done 
Running recipes io.jenkins.tools.pluginmodernizer.UpgradeToJava17 for plugin git-client... Please be patient 
Done 
Using minimum JDK 17 from metadata for plugin git-client 
Plugin git-client verified successfully with JDK 17 
Collecting metadata for plugin git-client... Please be patient 
Build failed 
Done 
Failed to read target metadata for plugin git-client 
************* 
Plugin: git-client 
Error: Build failed 
Error: Failed to read target metadata for plugin git-client 
************* 
Plugin Modernizer finished.

Expected Results

logs

Actual Results

error

Anything else?

No response

Are you interested in contributing a fix?

No response

jonesbusy commented 2 months ago

Can you provide --debug logs ?

I've tried the recipe on https://github.com/jenkinsci/git-client-plugin/pull/1187 and it seems to work. Except the recipe description that is wrong

Now the plugin has been upgraded already so without debug logs I'm not sure what happened

gounthar commented 1 month ago 
 java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar --debug --dry-run --plugins javadoc --recipes UpgradeToJava17 --export-datatables
Starting Plugin Modernizer
Maven version detected: 3.9.9
(368d5c00) GitHub API request: GET https://api.github.com/user
Plugins: [javadoc]
Recipes: io.jenkins.tools.pluginmodernizer.UpgradeToJava17
GitHub owner: gounthar
Update Center Url: https://updates.jenkins.io/current/update-center.actual.json
Plugin versions Url: https://updates.jenkins.io/current/plugin-versions.json
Plugin Health Score Url: https://plugin-health.jenkins.io/api/scores
Cache Path: /home/poddingue/.cache/jenkins-plugin-modernizer-cli
Dry Run: true
Skip Push: false
Skip Pull Request: false
Maven rewrite plugin version: 5.41.0
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path . and key plugin-versions
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path . and key update-center
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path . and key update-center
Plugin javadoc latest version: 280.v050b_5c849f69
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path . and key health-score
Plugin javadoc health score: 100.0
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path . and key update-center
Is API plugin javadoc : false
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path . and key update-center
(aaa0f76) GitHub API request: GET https://api.github.com/repos/jenkinsci/javadoc-plugin
Skipping forking plugin javadoc in dry-run mode
Skipping sync plugin javadoc in dry-run mode
(33956d1a) GitHub API request: GET https://api.github.com/repos/jenkinsci/javadoc-plugin
Fetch plugin code javadoc from https://github.com/jenkinsci/javadoc-plugin into directory javadoc-plugin...
Fetching javadoc
(2e1ddc90) GitHub API request: GET https://api.github.com/repos/jenkinsci/javadoc-plugin
Fetch successfully from https://github.com/jenkinsci/javadoc-plugin.git
Fetched repository from https://github.com/jenkinsci/javadoc-plugin
Cache entry not found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path javadoc and key plugin-metadata
No metadata or precondition errors found for plugin javadoc. Skipping initial compilation.
Collecting metadata for plugin javadoc... Please be patient
Validating POM for plugin: javadoc
JDK home: /home/poddingue/.sdkman/candidates/java/17.0.12-tem
Done
Moving object from /home/poddingue/.cache/jenkins-plugin-modernizer-cli/javadoc/sources/target/./plugin-metadata to /home/poddingue/.cache/jenkins-plugin-modernizer-cli/javadoc/plugin-metadata
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli/javadoc/sources/target at path . and key plugin-metadata
/home/poddingue/.cache/jenkins-plugin-modernizer-cli
Cache entry removed for key: plugin-metadata at location /home/poddingue/.cache/jenkins-plugin-modernizer-cli/javadoc/sources/target
Cache entry found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli at path javadoc and key plugin-metadata
Moved plugin javadoc metadata to cache: /home/poddingue/.cache/jenkins-plugin-modernizer-cli/javadoc/plugin-metadata
Running recipes io.jenkins.tools.pluginmodernizer.UpgradeToJava17 for plugin javadoc... Please be patient
Active recipes: io.jenkins.tools.pluginmodernizer.UpgradeToJava17
Validating POM for plugin: javadoc
JDK home: /home/poddingue/.sdkman/candidates/java/17.0.12-tem
Done
Using minimum JDK 17 from metadata for plugin javadoc
Plugin javadoc verified successfully with JDK 17
Failed to create target directory for plugin javadoc
Collecting metadata for plugin javadoc... Please be patient
Validating POM for plugin: javadoc
JDK home: /home/poddingue/.sdkman/candidates/java/17.0.12-tem
Build failed with code: 1
Done
Cache entry not found for cache /home/poddingue/.cache/jenkins-plugin-modernizer-cli/javadoc/sources/target at path . and key plugin-metadata
Failed to read target metadata for plugin javadoc
*************
Plugin: javadoc
Error: Build failed with code: 1
Stacktrace:
io.jenkins.tools.pluginmodernizer.core.model.PluginProcessingException: Build failed with code: 1
        at io.jenkins.tools.pluginmodernizer.core.model.Plugin.addError(Plugin.java:273)
        at io.jenkins.tools.pluginmodernizer.core.impl.MavenInvoker.handleInvocationResult(MavenInvoker.java:281)
        at io.jenkins.tools.pluginmodernizer.core.impl.MavenInvoker.invokeGoals(MavenInvoker.java:193)
        at io.jenkins.tools.pluginmodernizer.core.impl.MavenInvoker.collectMetadata(MavenInvoker.java:101)
        at io.jenkins.tools.pluginmodernizer.core.model.Plugin.collectMetadata(Plugin.java:472)
        at io.jenkins.tools.pluginmodernizer.core.impl.PluginModernizer.process(PluginModernizer.java:187)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
        at io.jenkins.tools.pluginmodernizer.core.impl.PluginModernizer.start(PluginModernizer.java:78)
        at io.jenkins.tools.pluginmodernizer.cli.Main.run(Main.java:222)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.executeHelpRequest(CommandLine.java:2016)
        at picocli.CommandLine.executeHelpRequest(CommandLine.java:1987)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2272)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at io.jenkins.tools.pluginmodernizer.cli.Main.main(Main.java:45)
Error: Failed to read target metadata for plugin javadoc
Stacktrace:
io.jenkins.tools.pluginmodernizer.core.model.PluginProcessingException: Failed to read target metadata for plugin javadoc
        at io.jenkins.tools.pluginmodernizer.core.model.Plugin.addError(Plugin.java:273)
        at io.jenkins.tools.pluginmodernizer.core.model.Plugin.readTargetMetadata(Plugin.java:669)
        at io.jenkins.tools.pluginmodernizer.core.impl.PluginModernizer.process(PluginModernizer.java:188)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
        at io.jenkins.tools.pluginmodernizer.core.impl.PluginModernizer.start(PluginModernizer.java:78)
        at io.jenkins.tools.pluginmodernizer.cli.Main.run(Main.java:222)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.executeHelpRequest(CommandLine.java:2016)
        at picocli.CommandLine.executeHelpRequest(CommandLine.java:1987)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2272)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at io.jenkins.tools.pluginmodernizer.cli.Main.main(Main.java:45)
*************
Plugin Modernizer finished.