Closed Mahmoudgalalz closed 1 year ago
also considering to put the pagination in the bottom
I prefer the current dense layout because it lets me see many plugins without scrolling. When I'm seeking a plugin that matches a specific word (like GitHub or Bitbucket or Gitea) there are usually multiple matches that I need to consider. The less dense layout that you're proposing will make less information fit on the screen for me.
@MarkEWaite what about pagination at the bottom, and making them centered? after collapsing the side nav
I'll need to experiment with my Chromebook with its narrow vertical space before I offer an opinion on pagination at top or bottom. I easily forget the experience navigating on a screen with limited vertical space when working at my desktop.
okay, also I have seen a new update on blog pagination we can do that there, and we can consider putting it in the Jenkins-components as it used on both sites
I see the issue has been closed. But since @halkeye asked for feedback here is what I have found:
Actually I prefer the current layout. It seems like the number of cards returned is responsive. So for my 13 inch laptop I see this:
Maybe the only improvement I see is actually needed is to optimise also for the 13 inch version to display 5 cards per row instead of 4. I think that can be easily done with a change of either padding/margin settings.
Yeah @krisstern, we can work on centering it and making enough cards per page, for each aspect ratio
I'm using a large screen that's why it has 8 per row, and this is good following
but I recommend being centered this will be good as there's an empty alignment on the right when the sidebar is closed so I can work on this and empty alignment on the left
I think some components like the pagination is already centered. Maybe we can try experimenting with centering the group of cards returned per search as well to give a more consistent look and feel.
hi @halkeye I looked at the blogs pagination it has been changed there so can the pagination be a component and used in the plugin site and blog site I have an implementation in my head, but I'm asking if it would be good to do, or just change it to the in the plugin site as the blog site
I think some component like the pagination is already centered. Maybe we can try experimenting with centering the group of cards returned per search as well to give a more consistent look and feel.
awesome I will work on it and send a PR now
Sounds good
this is not clear, and it's returning too many plugins
I recommend changing the layout to hold 4 cards and be centered when the side tab disappears
and changing the style to a bigger
similar to this but adding a good style to it I will send a pr if this considered with my suggested UI