jenkins-infra / plugin-site

This is the frontend application driven by data from the Jenkins Plugin Site API.
https://plugins.jenkins.io/
MIT License
20 stars 66 forks source link

#enhancment: changing the component style #1324

Closed Mahmoudgalalz closed 1 year ago

Mahmoudgalalz commented 1 year ago

image

this is not clear, and it's returning too many plugins

I recommend changing the layout to hold 4 cards and be centered when the side tab disappears

and changing the style to a bigger

similar to this but adding a good style to it image I will send a pr if this considered with my suggested UI

Mahmoudgalalz commented 1 year ago

also considering to put the pagination in the bottom

MarkEWaite commented 1 year ago

I prefer the current dense layout because it lets me see many plugins without scrolling. When I'm seeking a plugin that matches a specific word (like GitHub or Bitbucket or Gitea) there are usually multiple matches that I need to consider. The less dense layout that you're proposing will make less information fit on the screen for me.

Mahmoudgalalz commented 1 year ago

@MarkEWaite what about pagination at the bottom, and making them centered? after collapsing the side nav

MarkEWaite commented 1 year ago

I'll need to experiment with my Chromebook with its narrow vertical space before I offer an opinion on pagination at top or bottom. I easily forget the experience navigating on a screen with limited vertical space when working at my desktop.

Mahmoudgalalz commented 1 year ago

okay, also I have seen a new update on blog pagination Screenshot 2023-04-07 at 5 05 33 AM we can do that there, and we can consider putting it in the Jenkins-components as it used on both sites

krisstern commented 1 year ago

I see the issue has been closed. But since @halkeye asked for feedback here is what I have found:

Actually I prefer the current layout. It seems like the number of cards returned is responsive. So for my 13 inch laptop I see this:

Screenshot 2023-04-07 at 12 25 48 PM

Maybe the only improvement I see is actually needed is to optimise also for the 13 inch version to display 5 cards per row instead of 4. I think that can be easily done with a change of either padding/margin settings.

Mahmoudgalalz commented 1 year ago

Yeah @krisstern, we can work on centering it and making enough cards per page, for each aspect ratio

image I'm using a large screen that's why it has 8 per row, and this is good following

but I recommend being centered this will be good as there's an empty alignment on the right when the sidebar is closed so I can work on this and empty alignment on the left image

krisstern commented 1 year ago

I think some components like the pagination is already centered. Maybe we can try experimenting with centering the group of cards returned per search as well to give a more consistent look and feel.

Mahmoudgalalz commented 1 year ago

hi @halkeye I looked at the blogs pagination it has been changed there so can the pagination be a component and used in the plugin site and blog site I have an implementation in my head, but I'm asking if it would be good to do, or just change it to the in the plugin site as the blog site

Mahmoudgalalz commented 1 year ago

I think some component like the pagination is already centered. Maybe we can try experimenting with centering the group of cards returned per search as well to give a more consistent look and feel.

awesome I will work on it and send a PR now

krisstern commented 1 year ago

Sounds good

Mahmoudgalalz commented 1 year ago

1326 closed this issue