search

jenkins-infra / repository-permissions-updater

Artifactory permissions synchronization tool and data set
77 stars 1.03k forks source link

We may no longer need length limitations for groupId, artifactId #2619

Open daniel-beck opened 2 years ago

daniel-beck commented 2 years ago

What feature do you want to see added?

After https://github.com/jenkins-infra/update-center2/pull/605, we may no longer have a need for length limitations for groupId, artifactId.

RPU itself can handle names based on overly long artifact IDs in https://github.com/jenkins-infra/repository-permissions-updater/blob/4ae7713d7eb9fd166f028dbc7ab6fad1b3f39dee/src/main/groovy/io/jenkins/infra/repository_permissions_updater/ArtifactoryAPI.groovy#L138-L140.

Otherwise I'm not sure we need to limit lengths for infra reasons. We can probably relax the current lengths and allow longer values, but perhaps not fully unrestricted?

Upstream changes

No response

daniel-beck commented 2 years ago

2681 likely identifies a length limitation in GitHub repo names, which usually correspond with artifact ID.

jetersen commented 2 years ago

Can this be closed as well @daniel-beck ? or is it related to another API.

daniel-beck commented 2 years ago

Given that #2681 was a new discovery when I commented, it's unrelated.

timja commented 2 years ago

It's related as it was a reason to not lift the limitation isn't it?

Now that it's resolved we can possibly go ahead and remove the limitation?

daniel-beck commented 2 years ago

Now that it's resolved we can possibly go ahead and remove the limitation?

If there's no other reason to limit lengths. I don't know. Yoloing would not be a good idea.

timja commented 2 years ago

There's no known issues but I haven't rushed to remove this as I don't think it's harmful to have reasonable length names (i.e. not too long)