gitlab-kubernetes-credentials-plugin

[jonesbusy]

Repository URL

https://github.com/jonesbusy/gitlab-kubernetes-credentials-plugin

New Repository Name

gitlab-kubernetes-credentials-plugin

Description

Integrates the GitLab multibranch pipeline credential type from the gitlab-branch-source-plugin with the k8s credential provider (https://www.jenkins.io/doc/developer/extensions/kubernetes-credentials-provider/)

• SImilar to https://github.com/jenkinsci/bitbucket-kubernetes-credentials-plugin

GitHub users to have commit permission

@jonesbusy

Jenkins project users to have release permission

jonesbusy

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default. This message informs you that the security team was notified about the request and will soon participate in this issue to assist. The team is usually starting by a quick superficial audit and if it's not sufficient, they are planning a deeper audit.

Commands

Security team only:

• /audit-ok => the audit is complete, the hosting can continue :tada:.
• /audit-skip => the audit is not necessary, the hosting can continue :tada:.
• /audit-required => the superficial audit was not sufficient, a deeper look is necessary :mag:.
• /audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

• /audit-review => the findings from the audits were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message)

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @jonesbusy (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @jonesbusy (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jonesbusy]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @jonesbusy (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @jonesbusy (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

Fixed it for you, Jenkins project users must not be mentioned. The name specified equals the LDAP username, it's not the GitHub handle.

[NotMyFault]

Hey @jonesbusy,

I took a quick over your setup:

• https://github.com/jonesbusy/gitlab-kubernetes-credentials-plugin/blob/6db1635d20e35bd464ba971c5091d14ef31b5e61/pom.xml#L24 should be git:https rather than git:git, the latter is deprecated
• https://github.com/jonesbusy/gitlab-kubernetes-credentials-plugin/blob/6db1635d20e35bd464ba971c5091d14ef31b5e61/pom.xml#L62 you can drop the version, it's inherited by the bom.
• Your GAV coordinates picked don't align with the one you're actually using. I'd recommend you move your group id from io.jonesbusy.jenkins to io.jenkins.plugins, as specified appropriately in https://github.com/jonesbusy/gitlab-kubernetes-credentials-plugin/blob/6db1635d20e35bd464ba971c5091d14ef31b5e61/pom.xml#L11, but referenced incorrectly in https://github.com/jonesbusy/gitlab-kubernetes-credentials-plugin/tree/main/src/main/java/io/jonesbusy/jenkins/, package names and imports.

[jonesbusy]

Thanks @NotMyFault

I've fixed the following points

• Fix SCM urls on POM
• Fix dependencies version to use BOM
• Fix package names to match GAV

[yaroslavafenkin]

Seems fine security-wise after superficial look, you can proceed

[yaroslavafenkin]

/audit-ok

[NotMyFault]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/gitlab-kubernetes-credentials-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please remove your original repository (if there are no other forks) so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content: buildPlugin()

Welcome aboard!