search

jenkins-infra / repository-permissions-updater

Artifactory permissions synchronization tool and data set
76 stars 1.04k forks source link

Convert groovy classes to Java #3028

Open NotMyFault opened 1 year ago

NotMyFault commented 1 year ago

There are a few Groovy classes which should be moved to Java. Not only does that align with the tooling structure, it also allows us to drop the (very dated) groovy dependencies, to prepare for a more robust future in Java.

shivang-sharma commented 1 year ago

Hi @NotMyFault, I want to work on this issue. It will help a lot if you could point me to some documentation explaining how I can test and verify this repository once I make some changes. Thanks

NotMyFault commented 1 year ago

The Jenkinsfile contains the steps how this application is run: https://github.com/jenkins-infra/repository-permissions-updater/blob/a1333e4238948e3edb8f1b15e16f743db3cffcf5/Jenkinsfile#L46

daniel-beck commented 1 year ago

System properties and environment variables are documented at https://github.com/jenkins-infra/repository-permissions-updater#usage

shivang-sharma commented 1 year ago

Thankyou @NotMyFault and @daniel-beck for the info.

shivang-sharma commented 1 year ago

Hi @NotMyFault and @daniel-beck, Please review my first PR #3102. I need feedback for the below code. I have used @SuppressFBWarnings("URLCONNECTION_SSRF_FD") on line number 400 because I was getting this issue for the URL that is being used to open the connection I tried implementing a few checks but still I was getting this issue and @SuppressFBWarnings("DM_DEFAULT_ENCODING") at line number 333 because I was getting this issue while accessing the inputStream and outputStream of the connection. I have converted 1 file only and once this is approved I will work on the others and keep in mind all the suggestions and feedback from now on.

shivang-sharma commented 1 year ago

Hi @NotMyFault and @daniel-beck, Please review PR #3102.