Remote Build Result Trigger Plugin

[itfsw]

Repository URL

https://github.com/itfsw/remote-result-trigger-plugin

New Repository Name

remote-result-trigger-plugin

Description

Remote-Build-Result-Trigger-Plugin

A plugin for Jenkins CI that gives you the ability to monitor successful build on a remote Jenkins server.

Instructions

Enable the trigger within the "Remote Build Result Trigger" section of the build's configuration page.
When remote server build successful, plugin will trigger a local build and inject remote envs to job.

EVN_NAME	description
REMOTE_BUILD_NUMBER	The remote build number, such as "153".
REMOTE_BUILD_TIMESTAMP	The remote build timestamp, such as "1676017363424".
REMOTE_BUILD_URL	Full URL of this build, like https://server:port/jenkins/job/foo/15/ (Jenkins URL must be set).
REMOTE_${PARAMETER_NAME}	If remote job use buildWithParameters, use remote parameters replace ${PARAMETER_NAME}.

Screenshot

GitHub users to have commit permission

@itfsw

Jenkins project users to have release permission

itfsw

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a security scan was triggered on your repository. It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command. Security team only:

• /audit-ok => the audit is complete, the hosting can continue :tada:.
• /audit-skip => the audit is not necessary, the hosting can continue :tada:.
• /audit-required => the superficial audit was not sufficient, a deeper look is necessary :mag:.
• /audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

• /request-security-scan => the findings from the security scan were corrected, this command will re-scan your repository :mag:.
• /audit-review => the findings from the audits were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message)

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.328</jenkins.version> to at least 2.361.4 in your pom.xml. Take a look at the baseline recommendations.
• :no_entry: Required: You must use HTTPS for the <connection> tag in your <scm> block in your pom.xml. You can use this sample: <connection>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin.git</connection>
• :no_entry: Required: You must specify a <developerConnection> tag in your block in your pom.xml. You can use this sample: <developerConnection>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin</developerConnection>
• :no_entry: Required: The parent pom version '4.50' should be at least '4.52' or higher.
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: itfsw (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: itfsw (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[daniel-beck]

For a brand new plugin, https://github.com/itfsw/remote-result-trigger-plugin/blob/4d2abe990706536ca6deec12eed627858439ac00/pom.xml#L12-L14 is an indicator of a bad copy & paste from elsewhere. I suggest you go with a more recent core, and remove the compatibleSince.

https://github.com/itfsw/remote-result-trigger-plugin/blob/4d2abe990706536ca6deec12eed627858439ac00/pom.xml#L58-L78 I recommend you look into using https://github.com/jenkinsci/bom.

[jenkins-cert-app]

The CodeQL Scan discovered 5 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Jenkins: Missing permission check on a form fill web method with credentials lookup

You can find detailed information about this finding here.

CredentialsAuth.java#140

``` doFillCredentialsItems should perform a permission check before calling #lookupCredentials ```

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

CredentialsAuth.java#140

``` Potential CSRF vulnerability: If CredentialsAuthDescriptor#doFillCredentialsItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

Stapler: Missing permission check

You can find detailed information about this finding here.

CredentialsAuth.java#140

``` Potential missing permission check in CredentialsAuthDescriptor#doFillCredentialsItems ```

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

CredentialsAuth.java#30

``` Field should be reviewed whether it stores a password and is serialized to disk: credentials ```

Jenkins: Generally unsafe method calls

You can find detailed information about this finding here.

SSLSocketManager.java#20

``` Potentially unsafe invocation of SSLContext#init ```

[itfsw]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

/request-security-scan

[NotMyFault]

/audit-review

[jenkins-cert-app]

The CodeQL Scan discovered 5 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Jenkins: Missing permission check on a form fill web method with credentials lookup

You can find detailed information about this finding here.

CredentialsAuth.java#140

``` doFillCredentialsItems should perform a permission check before calling #lookupCredentials ```

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

CredentialsAuth.java#140

``` Potential CSRF vulnerability: If CredentialsAuthDescriptor#doFillCredentialsItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

Stapler: Missing permission check

You can find detailed information about this finding here.

CredentialsAuth.java#140

``` Potential missing permission check in CredentialsAuthDescriptor#doFillCredentialsItems ```

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

CredentialsAuth.java#30

``` Field should be reviewed whether it stores a password and is serialized to disk: credentials ```

Jenkins: Generally unsafe method calls

You can find detailed information about this finding here.

SSLSocketManager.java#20

``` Potentially unsafe invocation of SSLContext#init ```

[itfsw]

/request-security-scan

[NotMyFault]

@Wadeck Your bot -1's me :(

Is there a chance to react with "+1" when requesting a re-run?

[jenkins-cert-app]

The CodeQL Scan did not find anything dangerous with your plugin, congratulations! :tada:

[Wadeck]

@NotMyFault the -1 is because the "status" was not expected. I need to check what happened, there were lot of commands there :) (the -1 was on the audit-review not the re-run of the scan)

[NotMyFault]

Hey @itfsw,

I took a general look over your hosting request and have a few recommendations:

• https://github.com/itfsw/remote-result-trigger-plugin/blob/6a09f6f277e0b09eebb30044caa6f2b7ddfd255a/pom.xml#L13-L14 this should be removed
• https://github.com/itfsw/remote-result-trigger-plugin/blob/6a09f6f277e0b09eebb30044caa6f2b7ddfd255a/pom.xml#L17 new hosting requests use the groupId io.jenkins.plugins. Please adjust it and move your packages to io.jenkins.plugins too: https://github.com/itfsw/remote-result-trigger-plugin/tree/main/src/main/java/com/itfsw/
• As recommended by Daniel, you should add Jenkins' BOM to your pom.xml:

  <dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>io.jenkins.tools.bom</groupId>
      <artifactId>bom-2.361.x</artifactId>
      <version>1798.vc671fe94856f</version>
      <scope>import</scope>
      <type>pom</type>
    </dependency>
  </dependencies>
  </dependencyManagement>

  Followed by that, you can remove the <version> block from credentials, jackson2-api and okhttp-api

• https://github.com/itfsw/remote-result-trigger-plugin/blob/6a09f6f277e0b09eebb30044caa6f2b7ddfd255a/pom.xml#L64 this should be set to 1.0
• https://github.com/itfsw/remote-result-trigger-plugin/blob/6a09f6f277e0b09eebb30044caa6f2b7ddfd255a/pom.xml#L81-L85 apparently this is entirely unused. Hence, it should be removed.
• https://github.com/itfsw/remote-result-trigger-plugin/blob/main/Jenkinsfile should be updated accordingly to https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile
• Please create a .mvn/extensions.xml file with the following content: https://github.com/jenkinsci/git-plugin/blob/master/.mvn/extensions.xml
• Please create a .mvn/maven.config file with the following content: https://github.com/jenkinsci/git-plugin/blob/master/.mvn/maven.config
• Please create a .github/workflows/release-drafter.yml file with the following content: https://github.com/jenkinsci/git-plugin/blob/master/.github/workflows/release-drafter.yml. Replace master with main.
• Please create a .github/release-drafter.yml file with the following content. https://github.com/jenkinsci/git-plugin/blob/master/.github/release-drafter.yml. Replace git- with the artifact id of your plugin
• Please create a .github/dependabot.yml file with the following content: https://github.com/jenkinsci/console-column-plugin/blob/master/.github/dependabot.yml
• https://github.com/itfsw/remote-result-trigger-plugin/blob/6a09f6f277e0b09eebb30044caa6f2b7ddfd255a/pom.xml#L39-L41 This should point to the target location, specifying jenkinsci as repository owner.
• I recommend documenting code in English.

[itfsw]

@NotMyFault all fixed

[itfsw]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan did not find anything dangerous with your plugin, congratulations! :tada:

[daniel-beck]

https://github.com/itfsw/remote-result-trigger-plugin/blob/42a8c0f65973579a4ec06afd5c0deee2d67e26b0/src/main/java/io/jenkins/plugins/remote/result/trigger/auth2/CredentialsAuth.java#L151-L152 Only one of these is needed, they both independently accomplish that. Note that doFillCredentialsIdItems are not considered to have side effects, so a suppression here would also be fine.

https://github.com/itfsw/remote-result-trigger-plugin/blob/42a8c0f65973579a4ec06afd5c0deee2d67e26b0/src/main/java/io/jenkins/plugins/remote/result/trigger/RemoteBuildResultTrigger.java#L194 looks like an unsafe default. Unsure what use case this being Boolean covers, that looks like something added for backwards compatibility with an older release (bad copy & paste again?). Should be easier with a boolean and defaulting to not trust.

[itfsw]

@daniel-beck

1. doFillCredentialsIdItems has removed RequirePOST.
2. "Unsure what use case this being Boolean covers, that looks like something added for backwards compatibility with an older release (bad copy & paste again?)", ....I found the problem，it's used to my local test，I will remove it.

[itfsw]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan discovered 2 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

RemoteBuildResultTrigger.java#235

``` Potential CSRF vulnerability: If RemoteBuildResultTriggerDescriptor#doCheckRemoteJenkinsUrl connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

Stapler: Missing permission check

You can find detailed information about this finding here.

RemoteBuildResultTrigger.java#235

``` Potential missing permission check in RemoteBuildResultTriggerDescriptor#doCheckRemoteJenkinsUrl ```

Jenkins: Generally unsafe method calls

You can find detailed information about this finding here.

[itfsw]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan discovered 1 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Stapler: Missing permission check

You can find detailed information about this finding here.

RemoteBuildResultTrigger.java#237

``` Potential missing permission check in RemoteBuildResultTriggerDescriptor#doCheckRemoteJenkinsUrl ```

Jenkins: Generally unsafe method calls

You can find detailed information about this finding here.

[itfsw]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan did not find anything dangerous with your plugin, congratulations! :tada:

[NotMyFault]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[itfsw]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan did not find anything dangerous with your plugin, congratulations! :tada:

[NotMyFault]

Hey @itfsw,

• https://github.com/itfsw/remote-result-trigger-plugin/blob/fef71138492ef63b4c9c31f878d5bf9d5aa0fbcd/.github/release-drafter.yml#L2 is incorrect. You should point it to your artifactId specific in the pom.xml
• https://github.com/itfsw/remote-result-trigger-plugin/blob/fef71138492ef63b4c9c31f878d5bf9d5aa0fbcd/pom.xml#L79 I recommend using a more up-to-date version, like 5.1.1
• You're using various deprecated calls in the classes located in the auth package. You probably want to see whether you can use the drop in replacement methods.
• I can spot a few common spotbugs pitfalls. You can run mvn clean verify package to get a list of all failures to address.

[itfsw]

@NotMyFault Thanks for review，all need fixed has done. But i have pull new version to support monitor more than one remote jobs. So we need a new review.

New Readme

[itfsw]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan discovered 3 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Stapler: Missing permission check

You can find detailed information about this finding here.

RemoteJenkinsServer.java#110

``` Potential missing permission check in DescriptorImpl#doCheckUrl ```

RemoteJobInfo.java#102

``` Potential missing permission check in DescriptorImpl#doFillRemoteJenkinsServerItems ```

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

RemoteJobResultUtils.java#283

``` Field should be reviewed whether it stores a password and is serialized to disk: serverJobKey ```

[itfsw]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan did not find anything dangerous with your plugin, congratulations! :tada:

[NotMyFault]

/request-security-scan

[jenkins-cert-app]

The CodeQL Scan did not find anything dangerous with your plugin, congratulations! :tada:

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/remote-result-trigger-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content: buildPlugin(useContainerAgent: true, jdkVersions: [8, 11])

Welcome aboard!