search

jenkins-infra / repository-permissions-updater

Artifactory permissions synchronization tool and data set
77 stars 1.03k forks source link

apache-httpcomponents-client-5-api-plugin #3167

Closed strangelookingnerd closed 1 year ago

strangelookingnerd commented 1 year ago

Repository URL

https://github.com/strangelookingnerd/apache-httpcomponents-client-5-api-plugin

New Repository Name

apache-httpcomponents-client-5-api-plugin

Description

Similar to https://github.com/jenkinsci/apache-httpcomponents-client-4-api-plugin this plugin bundles https://hc.apache.org/httpcomponents-client-5.2.x/index.html and allows it to be used by Jenkins plugins.

GitHub users to have commit permission

@strangelookingnerd

Jenkins project users to have release permission

strangelookingnerd

Issue tracker

GitHub issues

jenkins-cert-app commented 1 year ago

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a security scan was triggered on your repository. It takes ~10 minutes to complete.

Commands The bot will parse all comments, and it will check if any line start with a command. Security team only:
  • /audit-ok => the audit is complete, the hosting can continue :tada:.
  • /audit-skip => the audit is not necessary, the hosting can continue :tada:.
  • /audit-required => the superficial audit was not sufficient, a deeper look is necessary :mag:.
  • /audit-findings => the audit reveals some issues that require corrections :pencil2:.
Anyone:
  • /request-security-scan => the findings from the security scan were corrected, this command will re-scan your repository :mag:.
  • /audit-review => the findings from the audits were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.
Only one command can be requested per comment.

(automatically generated message, version: 1.15.2)

github-actions[bot] commented 1 year ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

strangelookingnerd commented 1 year ago

/hosting re-check

github-actions[bot] commented 1 year ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 1 year ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

jenkins-cert-app commented 1 year ago

The CodeQL Scan did not find anything dangerous with your plugin, congratulations! :tada:

github-actions[bot] commented 1 year ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A human volunteer will check over things that I am not able to check for (code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

NotMyFault commented 1 year ago

Is there a demand for bundling http5 as a library? Currently, there is only one plugin, which depends on httpclient5, which could migrate to this library. It appears that OkHttp is the go-to way, based on installation numbers.

timja commented 1 year ago

You probably don't need to depend on the bom in a library plugin that is unlikely to have other Jenkins dependencies:

https://github.com/strangelookingnerd/apache-httpcomponents-client-5-api-plugin/blob/ffc41dce24e264cf4555ffdea8e1903c4c2161d8/pom.xml#L54-L64

It appears that OkHttp is the go-to way, based on installation numbers

🤷 just historical reasons I think. I would expect more and more plugins to drop those deps and to use the Java 11 HttpClient by default, and to use the others where libraries depend on them.

strangelookingnerd commented 1 year ago

Is there a demand for bundling http5 as a library? Currently, there is only one plugin, which depends on httpclient5, which could migrate to this library. It appears that OkHttp is the go-to way, based on installation numbers.

Not to argue with that at all, just thought it would be a good alternative. Further there are plenty plugins that depend on apache-httpcomponents-client-4-api that could be upgraded.

NotMyFault commented 1 year ago

I would expect more and more plugins to drop those deps and to use the Java 11 HttpClient by default, and to use the others where libraries depend on them.

I don't mind too much, modern and maintained dependencies make a great alternative.

NotMyFault commented 1 year ago

Hey @strangelookingnerd,

I have some general feedback to your hosting request:

strangelookingnerd commented 1 year ago

@NotMyFault Thanks for the feedback. Didn't now, that properties could be used that way in jelly. In my local test it does not show up though:

image

Is this a bug or something not working properly in my local setup? Same results when running via hpi:run as well as in local jenkins.war.

NotMyFault commented 1 year ago

I don't actively maintain any libraries, but this works well for others: https://github.com/jenkinsci/commons-lang3-api-plugin/blob/6c324cc5b4d12bff883e4d757ebf35e5cc46d74a/src/main/resources/index.jelly#L7

Although, not a hosting blocker.

NotMyFault commented 1 year ago

/hosting host

jenkins-infra-bot commented 1 year ago

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/apache-httpcomponents-client-5-api-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content: buildPlugin(useContainerAgent: true, jdkVersions: [8, 11])

Welcome aboard!