Loadmance Plugin

[aktoluna]

Repository URL

https://github.com/virgosol/loadmance-plugin

New Repository Name

loadmance-plugin

Description

We would like to publish the plugin I wrote for our Loadmance product.

GitHub users to have commit permission

@aktoluna

Jenkins project users to have release permission

aktoluna

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository. It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command. Security team only:

• /audit-ok => the audit is complete, the hosting can continue :tada:.
• /audit-skip => the audit is not necessary, the hosting can continue :tada:.
• /audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

• /request-security-scan => the findings from the [Jenkins Security Scan](https://www.jenkins.io/doc/developer/security/scan/) were corrected, this command will re-scan your repository :mag:.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.17.22)

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.361.4</jenkins.version> to at least 2.387.3 in your pom.xml. Take a look at the baseline recommendations.
• :no_entry: Required: You must use HTTPS for the <connection> tag in your <scm> block in your pom.xml. You can use this sample: <connection>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin.git</connection>
• :no_entry: Required: The parent pom version '4.52' should be at least '4.65' or higher.
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[aktoluna]

/hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan discovered 14 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Remoting: Unsafe Callable

You can find detailed information about this finding here.

LoadmanceBuild.java#80

``` Potentially unsafe Callable implementation LoadmanceBuild#checkRoles ```

Jenkins: Missing permission check on a form fill web method with credentials lookup

You can find detailed information about this finding here.

LoadmanceBuilder.java#189

``` doFillTestIdItems should perform a permission check before calling #lookupCredentials ```

LoadmanceBuilder.java#161

``` doFillProjectIdItems should perform a permission check before calling #lookupCredentials ```

LoadmanceBuilder.java#146

``` doFillCredentialsIdItems should perform a permission check before calling #lookupCredentials ```

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

LoadmanceBuilder.java#189

``` Potential CSRF vulnerability: If DescriptorImpl#doFillTestIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

LoadmanceBuilder.java#161

``` Potential CSRF vulnerability: If DescriptorImpl#doFillProjectIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

LoadmanceBuilder.java#146

``` Potential CSRF vulnerability: If DescriptorImpl#doFillCredentialsIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

LoadmanceCredentials.java#50

``` Potential CSRF vulnerability: If DescriptorImpl#doTestConnection connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

Stapler: Missing permission check

You can find detailed information about this finding here.

LoadmanceBuilder.java#189

``` Potential missing permission check in DescriptorImpl#doFillTestIdItems ```

LoadmanceBuilder.java#161

``` Potential missing permission check in DescriptorImpl#doFillProjectIdItems ```

LoadmanceBuilder.java#146

``` Potential missing permission check in DescriptorImpl#doFillCredentialsIdItems ```

LoadmanceCredentials.java#50

``` Potential missing permission check in DescriptorImpl#doTestConnection ```

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

AuthRequestDto.java#5

``` Field should be reviewed whether it stores a password and is serialized to disk: password ```

LoginResponseDto.java#5

``` Field should be reviewed whether it stores a password and is serialized to disk: token ```

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[aktoluna]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[aktoluna]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[NotMyFault]

Hey @aktoluna,

I took a look over your hosting request and have some feedback for you:

• https://github.com/virgosol/loadmance-plugin/blob/main/.github/CODEOWNERS should point to your artifact Id
• https://github.com/virgosol/loadmance-plugin/blob/9411149fadf1435baae464871ec071b83afb0eac/.github/release-drafter.yml#L2 same point like above
• https://github.com/virgosol/loadmance-plugin/blob/9411149fadf1435baae464871ec071b83afb0eac/.mvn/extensions.xml#L5 should be 1.6
• https://github.com/virgosol/loadmance-plugin/blob/main/src/main/resources/index.jelly Please fill in a short description what this plugin is about.
• https://github.com/virgosol/loadmance-plugin/blob/9411149fadf1435baae464871ec071b83afb0eac/pom.xml#L46-L49 is obsolete and should be removed.
• https://github.com/virgosol/loadmance-plugin/blob/9411149fadf1435baae464871ec071b83afb0eac/pom.xml#L71-L99 Remove all dependencies your plugin doesn't depend on
• https://github.com/virgosol/loadmance-plugin/blob/9411149fadf1435baae464871ec071b83afb0eac/pom.xml#L100-L104 instead of shading jackson yourself, you can depend on the corresponding Jenkins plugin shipping it: https://plugins.jenkins.io/jackson2-api/dependencies/
• https://github.com/virgosol/loadmance-plugin/blob/9411149fadf1435baae464871ec071b83afb0eac/pom.xml#L105-L109 appears to be obsolete and should be removed
• https://github.com/virgosol/loadmance-plugin/blob/main/README.md Provide some information what this plugin is about, how it works and how you set it up.
• Make sure to address the errors highlighted when building the plugin: mvn clean verify package.

[mawinter69]

• https://github.com/virgosol/loadmance-plugin/blob/9411149fadf1435baae464871ec071b83afb0eac/src/main/java/io/jenkins/plugins/loadmance/LoadmanceCredentials.java#L16 This class seems to be a re-implementation of https://github.com/jenkinsci/credentials-plugin/blob/master/src/main/java/com/cloudbees/plugins/credentials/impl/UsernamePasswordCredentialsImpl.java So why not simply use https://github.com/jenkinsci/credentials-plugin/blob/master/src/main/java/com/cloudbees/plugins/credentials/common/StandardUsernamePasswordCredentials.java
• You implement a Builder, that means it can't be used in pipelines. It should be easy to use SimpleBuildStep instead
• https://github.com/virgosol/loadmance-plugin/blob/main/src/main/resources/app.properties should probably be moved into package io.jenkins.plugins.loadmance to avoid conflicts with other plugins in case they also have the idea to create file app.properties

[aktoluna]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @aktoluna (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[aktoluna]

/hosting host

[mawinter69]

• https://github.com/virgosol/loadmance-plugin/blob/7311067d233b7ce79f9562242a5031b3567575c0/src/main/java/io/jenkins/plugins/loadmance/LoadmanceBuilder.java#L77 this should override perform(Run<?, ?>, ...) otherwise you're still not able to use it in a pipeline (pipelines do not inherit from AbstractBuild or Build)
• https://github.com/virgosol/loadmance-plugin/blob/7311067d233b7ce79f9562242a5031b3567575c0/src/main/java/io/jenkins/plugins/loadmance/LoadmanceBuilder.java#L139 give your extension a meaningful name with @Symbol("loadmance") Then you can use it in a pipeline by just referring to loadmance credentialsId: mycredId, projectId: myprjId, testId: mytstId

[mawinter69]

• https://github.com/virgosol/loadmance-plugin/blob/7311067d233b7ce79f9562242a5031b3567575c0/pom.xml#L53 the artifactid of the bom is out of sync with the Jenkins version should be bom-2.387.x
• https://github.com/virgosol/loadmance-plugin/blob/7311067d233b7ce79f9562242a5031b3567575c0/pom.xml#L54 the version of the bom is outdated

[aktoluna]

Hi,

https://github.com/virgosol/loadmance-plugin/blob/7311067d233b7ce79f9562242a5031b3567575c0/src/main/java/io/jenkins/plugins/loadmance/LoadmanceBuilder.java#L77 this should override perform(Run, ...) otherwise you're still not able to use it in a pipeline (pipelines do not inherit from AbstractBuild or Build)

I did this but I don't know if it's right. Do you have a chance to share an example?

[aktoluna]

/hosting host

[mawinter69]

looks good I would say. Try out if it works in a pipeline

[aktoluna]

Ok, thank you:) I will try

[aktoluna]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[aktoluna]

/hosting host

[NotMyFault]

/request-security-scan

[NotMyFault]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[jenkins-cert-app]

The Jenkins Security Scan discovered 8 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Jenkins: Missing permission check on a form fill web method with credentials lookup

You can find detailed information about this finding here.

LoadmanceBuilder.java#211

``` doFillTestIdItems should perform a permission check before calling #lookupCredentials ```

LoadmanceBuilder.java#182

``` doFillProjectIdItems should perform a permission check before calling #lookupCredentials ```

LoadmanceBuilder.java#166

``` doFillCredentialsIdItems should perform a permission check before calling #lookupCredentials ```

Stapler: Missing permission check

You can find detailed information about this finding here.

LoadmanceBuilder.java#211

``` Potential missing permission check in DescriptorImpl#doFillTestIdItems ```

LoadmanceBuilder.java#182

``` Potential missing permission check in DescriptorImpl#doFillProjectIdItems ```

LoadmanceBuilder.java#166

``` Potential missing permission check in DescriptorImpl#doFillCredentialsIdItems ```

LoadmanceCredentials.java#52

``` Potential missing permission check in DescriptorImpl#doTestConnection ```

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

LoginResponseDto.java#5

``` Field should be reviewed whether it stores a password and is serialized to disk: token ```

[aktoluna]

/request-security-scan

[aktoluna]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[aktoluna]

/hosting host

[jenkins-cert-app]

The Jenkins Security Scan discovered 6 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Jenkins: Missing permission check on a form fill web method with credentials lookup

You can find detailed information about this finding here.

LoadmanceBuilder.java#219

``` doFillTestIdItems should perform a permission check before calling #lookupCredentials ```

LoadmanceBuilder.java#183

``` doFillProjectIdItems should perform a permission check before calling #lookupCredentials ```

LoadmanceBuilder.java#164

``` doFillCredentialsIdItems should perform a permission check before calling #lookupCredentials ```

Stapler: Missing permission check

You can find detailed information about this finding here.

LoadmanceBuilder.java#219

``` Potential missing permission check in DescriptorImpl#doFillTestIdItems ```

LoadmanceBuilder.java#183

``` Potential missing permission check in DescriptorImpl#doFillProjectIdItems ```

LoadmanceBuilder.java#164

``` Potential missing permission check in DescriptorImpl#doFillCredentialsIdItems ```

[aktoluna]

/request-security-scan

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

---

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

[aktoluna]

/hosting host

[NotMyFault]

Thanks for addressing the feedback @aktoluna, and thanks @mawinter69 for reviewing. Do you want to take another look?

[aktoluna]

Thank you @NotMyFault . Everything seems appropriate for me.

[mawinter69]

the bom version is a bit old but other than that it looks good

[NotMyFault]

the bom version is a bit old but other than that it looks good

Dependabot will pick that up, now worries.

[NotMyFault]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/loadmance-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content: https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

Welcome aboard!