Hosting request for Trunk.io plugin

[zaycev]

Repository URL

https://github.com/trunk-io/jenkins-plugin

New Repository Name

trunk-io-plugin

Description

This plugin integrates Jenkins with Trunk.io CI Analytics.

GitHub users to have commit permission

@zaycev

Jenkins project users to have release permission

zaycev

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository. It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command. Security team only:

• /audit-ok => the audit is complete, the hosting can continue :tada:.
• /audit-skip => the audit is not necessary, the hosting can continue :tada:.
• /audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.19.14)

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.387.1</jenkins.version> to at least 2.387.3 in your pom.xml. Take a look at the baseline recommendations.
• :no_entry: Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
• :no_entry: Required: The parent pom version '4.65' should be at least '4.71' or higher.
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @zaycev, @mmatheson, @dapirian (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @zaycev, @mmatheson, @dapirian (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The 'artifactId' from the pom.xml (trunk) is incorrect, it should be trunk-io ('New Repository Name' field with "-plugin" removed)
• :no_entry: Required: The <groupId> from the pom.xml should be io.jenkins.plugins instead of org.trunk.jenkins.plugins

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.387.1</jenkins.version> to at least 2.387.3 in your pom.xml. Take a look at the baseline recommendations.
• :no_entry: Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
• :no_entry: Required: The parent pom version '4.65' should be at least '4.71' or higher.
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @zaycev, @mmatheson, @dapirian (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @zaycev, @mmatheson, @dapirian (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The 'artifactId' from the pom.xml (trunk) is incorrect, it should be trunk-io ('New Repository Name' field with "-plugin" removed)
• :no_entry: Required: The <groupId> from the pom.xml should be io.jenkins.plugins instead of org.trunk.jenkins.plugins

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan discovered 1 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

Configuration.java#13

``` Field should be reviewed whether it stores a password and is serialized to disk: token ```

[zaycev]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: You must use HTTPS for the <connection> tag in your <scm> block in your pom.xml. You can use this sample: <connection>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin.git</connection>
• :no_entry: Required: You must specify an <url> tag in your <scm> block in your pom.xml. You can use this sample: <url>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin</url>
• :no_entry: Required: You must specify a <developerConnection> tag in your block in your pom.xml. You can use this sample: <developerConnection>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin</developerConnection>
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The <groupId> from the pom.xml should be io.jenkins.plugins instead of org.trunk.jenkins.plugins

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[zaycev]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[zaycev]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[zaycev]

/request-security-scan

[zaycev]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

---

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

[zaycev]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[zaycev]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: zaycev (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[zaycev]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

Hey @zaycev,

I took a brief look over your hosting request and have some general feedback for you:

• Create a .github folder within the repository root containing the following files and subdirectories: https://github.com/jenkinsci/archetypes/tree/master/common-files/.github
• Create a .mvn folder within the repository root with the following files: https://github.com/jenkinsci/archetypes/tree/master/common-files/.mvn
• https://github.com/trunk-io/jenkins-plugin/blob/main/CHANGELOG.md is obsolete and can be removed. Changelog files are not honored to populate release notes on the plugin site. Rather, publish them via GitHub releases, which has a direct integration with the plugin site (or via the release drafter action).
• https://github.com/trunk-io/jenkins-plugin/blob/9c848505d6de54bb54a0dab6eb813b283bee851b/pom.xml#L53 should point to jenkinsci/
• https://github.com/trunk-io/jenkins-plugin/blob/9c848505d6de54bb54a0dab6eb813b283bee851b/pom.xml#L82-L174 Please revise your list of dependencies. Lots of them are either default dependencies, or are not directly needed for the plugin and can be removed.

[zaycev]

Hey @zaycev,

I took a brief look over your hosting request and have some general feedback for you:

• Create a .github folder within the repository root containing the following files and subdirectories: https://github.com/jenkinsci/archetypes/tree/master/common-files/.github
• Create a .mvn folder within the repository root with the following files: https://github.com/jenkinsci/archetypes/tree/master/common-files/.mvn
• https://github.com/trunk-io/jenkins-plugin/blob/main/CHANGELOG.md is obsolete and can be removed. Changelog files are not honored to populate release notes on the plugin site. Rather, publish them via GitHub releases, which has a direct integration with the plugin site (or via the release drafter action).
• https://github.com/trunk-io/jenkins-plugin/blob/9c848505d6de54bb54a0dab6eb813b283bee851b/pom.xml#L53 should point to jenkinsci/
• https://github.com/trunk-io/jenkins-plugin/blob/9c848505d6de54bb54a0dab6eb813b283bee851b/pom.xml#L82-L174 Please revise your list of dependencies. Lots of them are either default dependencies, or are not directly needed for the plugin and can be removed.

Hi @NotMyFault

Thank you for your feedback! Our repo was updated to address these. Here are corresponding PRs which were landed to main branch: https://github.com/trunk-io/jenkins-plugin/pull/9/files and https://github.com/trunk-io/jenkins-plugin/pull/15/files.

Please let me know if there is anything else we need to do to get plugin hosted.

[NotMyFault]

Thanks, I took an additional look over your list of dependencies, and there's room for improvement left. Currently, the .hpi sizes 7M. I'd recommend to

• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L88-L92 remove maven. You don't need to shade it into the plugin.
• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L93-L97 instead of shading okhttp yourself, you can depend on the corresponding Jenkins plugin: https://plugins.jenkins.io/okhttp-api/dependencies/ It provides OkHTTP at runtime.
• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L114-L118 can be removed too, Jenkins core provides it already
• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L86 can be removed too, the GitHub plugin version is shipped by the BOM.

Keeping the recommendations in mind, the plugin becomes far more lightweight with ~600kb

[zaycev]

Thanks, I took an additional look over your list of dependencies, and there's room for improvement left. Currently, the .hpi sizes 7M. I'd recommend to

• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L88-L92 remove maven. You don't need to shade it into the plugin.
• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L93-L97 instead of shading okhttp yourself, you can depend on the corresponding Jenkins plugin: https://plugins.jenkins.io/okhttp-api/dependencies/ It provides OkHTTP at runtime.
• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L114-L118 can be removed too, Jenkins core provides it already
• https://github.com/trunk-io/jenkins-plugin/blob/e593bf429803fedd3db57f10d17a931b227389de/pom.xml#L86 can be removed too, the GitHub plugin version is shipped by the BOM.

Keeping the recommendations in mind, the plugin becomes far more lightweight with ~600kb

Thank you! Landed all recommendations on main. I can confirm ~640kb size after reusing what's already shipped with Jenkins:

.rw-r--r--@ 641k   1256 zv   staff 23 Aug 10:15   -I trunk-io.hpi

[NotMyFault]

/hosting re-check

[NotMyFault]

/request-security-scan

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

---

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

[NotMyFault]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/trunk-io-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content: https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

Welcome aboard!

[daniel-beck]

[ASSIST] @zaycev FYI you released version "y" of the plugin. That version is being filtered as it's non-numeric, so it will not be published.

To accept defaults in Maven, just press Enter/Return.

[zaycev]

@zaycev FYI you released version "y" of the plugin. That version is being filtered as it's non-numeric, so it will not be published.

To accept defaults in Maven, just press Enter/Return.

Sorry, accidentally typed y in mvn cli. I'm going do another release with corrected version. I also deleted it from GH releases.

[zaycev]

@daniel-beck thanks for the headsup.

[zaycev]

@daniel-beck not sure if this is the right place to ask. Wonder quickly releases on GH and Artifactory are propagated to https://plugins.jenkins.io or become available at "Available Plugins" sections in Jenkins?