Hosting for the Github Release Plugin

[jcustenborder]

Repository URL

https://github.com/jcustenborder/github-release-plugin

New Repository Name

github-release-plugin

Description

This plugin is used to create and list Github releases from a Jenkins Pipeline.

GitHub users to have commit permission

jcustenborder

Jenkins project users to have release permission

jcustenborder

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository. It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command. Security team only:

• /audit-ok => the audit is complete, the hosting can continue :tada:.
• /audit-skip => the audit is not necessary, the hosting can continue :tada:.
• /audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.17)

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.361.4</jenkins.version> to at least 2.387.3 in your pom.xml. Take a look at the baseline recommendations.
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: jcustenborder (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The 'artifactId' from the pom.xml (github-release-plugin) is incorrect, it should be github-release ('New Repository Name' field with "-plugin" removed)
• :no_entry: Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.361.4</jenkins.version> to at least 2.387.3 in your pom.xml. Take a look at the baseline recommendations.
• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: jcustenborder (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: The 'artifactId' from the pom.xml (github-release-plugin) is incorrect, it should be github-release ('New Repository Name' field with "-plugin" removed)
• :no_entry: Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.
• :no_entry: Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan discovered 4 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Jenkins: Missing permission check on a form fill web method with credentials lookup

You can find detailed information about this finding here.

ListReleasesStep.java#120

``` doFillSortByItems should perform a permission check before calling #includeEmptyValue ```

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

AbstractReleaseDescriptor.java#13

``` Potential CSRF vulnerability: If AbstractReleaseDescriptor#doFillCredentialIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

ListReleasesStep.java#120

``` Potential CSRF vulnerability: If DescriptorImpl#doFillSortByItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

Stapler: Missing permission check

You can find detailed information about this finding here.

ListReleasesStep.java#120

``` Potential missing permission check in DescriptorImpl#doFillSortByItems ```

[jcustenborder]

/request-security-scan

[jcustenborder]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: jcustenborder (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: jcustenborder (reports are re-synced hourly, wait to re-check for a bit after logging in)
• :no_entry: Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan discovered 3 finding(s) :mag:. For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Jenkins: Missing permission check on a form fill web method with credentials lookup

You can find detailed information about this finding here.

ListReleasesStep.java#121

``` doFillSortByItems should perform a permission check before calling #includeEmptyValue ```

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

AbstractReleaseDescriptor.java#13

``` Potential CSRF vulnerability: If AbstractReleaseDescriptor#doFillCredentialIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

ListReleasesStep.java#121

``` Potential CSRF vulnerability: If DescriptorImpl#doFillSortByItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

[jcustenborder]

/request-security-scan

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• :no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: jcustenborder (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

---

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

[jcustenborder]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

Hey @jcustenborder,

I took a brief look over your hosting request and have some feedback for you:

• Create a .github folder within the repository root including the following files and directories: https://github.com/jenkinsci/archetypes/tree/master/common-files/.github
• Create a .mvn folder within the repository root including the following files: https://github.com/jenkinsci/archetypes/tree/master/common-files/.mvn
• https://github.com/jcustenborder/github-release-plugin/blob/a4aef861fa9ce89215fca4329b2b971a499c7059/pom.xml#L15-L16 is wrong and should be removed. The plugin has no prior release it could declare incompatibility with.
• https://github.com/jcustenborder/github-release-plugin/blob/a4aef861fa9ce89215fca4329b2b971a499c7059/pom.xml#L39 should always match your jenkins.version specified.
• https://github.com/jcustenborder/github-release-plugin/blob/a4aef861fa9ce89215fca4329b2b971a499c7059/pom.xml#L99 The <compile> scope is obsolete for Jenkins plugins and should be removed.
• https://github.com/jcustenborder/github-release-plugin/blob/a4aef861fa9ce89215fca4329b2b971a499c7059/pom.xml#L109-L132 should be simplified to https://github.com/jenkinsci/archetypes/blob/282d79c14f8453bdffe1c74d5010dfdcf776ed9f/empty-plugin/src/main/resources/archetype-resources/pom.xml#L53-L64
• https://github.com/jcustenborder/github-release-plugin/blob/a4aef861fa9ce89215fca4329b2b971a499c7059/pom.xml#L134-L140 ssh as scm connection is deprecated for removal. Rather, point the connection and developerConnection to use https, like in https://github.com/jenkinsci/console-column-plugin/blob/bb152d70547e3906218869011072f744e6a0b03a/pom.xml#L63-L64
• https://github.com/jcustenborder/github-release-plugin/tree/main/src/main/java/org/jenkinsci/plugins/ uses the wrong class path. Please move your classes and files to io.jenkins.plugins.
• There are a few issues left to address within the codebase. You can generate a list via mvn clean verify package.
• Please update your Jenkinsfile matching the content of https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

[jcustenborder]

@NotMyFault Thank you for looking into this. Your effort is much appreciated. I believe I have addressed all of the issues you've raised.

[NotMyFault]

• https://github.com/jcustenborder/github-release-plugin/blob/main/.github/release-drafter.yml Looks like something went wrong here. The placeholder to fill out in the CODEOWNERS file is left too.

[NotMyFault]

/request-security-scan

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

---

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

[NotMyFault]

/hosting re-check

[github-actions[bot]]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/github-release-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content: https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

Welcome aboard!