Request to host new JENKINS plugin

OlegGavri commented 8 months ago

Repository URL

New Repository Name

global-pipeline-parameters-plugin

Description

This plugin allow any Pipeline Jobs store and read values common for all jobs. This values will be shared between all jobs in Jenkins Instance.

GitHub users to have commit permission

@reffum

Jenkins project users to have release permission

reffum

Issue tracker

Jira

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The origin repository 'https://github.com/OlegGavri/gparms.git' ends in .git, please remove this
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: Repository URL 'https://github.com/OlegGavri/gparms' is not a valid GitHub repository (check that you do not have .git at the end, GitHub API doesn't support this).
:warning: Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

jenkins-cert-app commented 8 months ago

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository. It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command. Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.0)

jenkins-cert-app commented 8 months ago

:x: Jenkins Security Scan failed. The Security team was notified about this.

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The parent pom version '4.76' should be at least '4.78' or higher.
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The 'artifactId' from the pom.xml (gparams) is incorrect, it should be gparam ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The parent pom version '4.76' should be at least '4.78' or higher.
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The parent pom version '4.76' should be at least '4.78' or higher.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The parent pom version '4.76' should be at least '4.78' or higher.
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The parent pom version '4.76' should be at least '4.78' or higher.
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: reffum (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Wadeck commented 8 months ago

❌ Jenkins Security Scan failed. The Security team was notified about this.

=>

[2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.51:hpi (default-hpi) on project gparams: Missing /tmp/tmp.a3B2uGcvUx/git-clone/target/classes/index.jelly. ~Delete any from pom.xml and~ create src/main/resources/index.jelly: [2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] <?jelly escape-by-default='true'?> [2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] \
[2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] The description here… [2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] \

In other words, the tooling expects you to have a src/main/resources/index.jelly with description about what your plugin is doing.

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The parent pom version '4.76' should be at least '4.78' or higher.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

OlegGavri commented 8 months ago

/hosting re-check

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

OlegGavri commented 8 months ago

❌ Jenkins Security Scan failed. The Security team was notified about this.

=>

[2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.51:hpi (default-hpi) on project gparams: Missing /tmp/tmp.a3B2uGcvUx/git-clone/target/classes/index.jelly. ~Delete any from pom.xml and~ create src/main/resources/index.jelly: [2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] [2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR]
[2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR] The description here… [2024-03-19 12:58:04] [build-stdout] [2024-03-19 12:58:04] [autobuild] [ERROR]

In other words, the tooling expects you to have a src/main/resources/index.jelly with description about what your plugin is doing.

Fix it. Add index.jelly.

NotMyFault commented 8 months ago

The plugin's functionality is already covered by the parameterized trigger plugin and by using shared pipelines. The latter exists exactly for this reason.

OlegGavri commented 8 months ago

The plugin's functionality is already covered by the parameterized trigger plugin and by using shared pipelines. The latter exists exactly for this reason.

Hello! Thank you for answer. I know about this two possibilities. I also try to use it, but they did not suit in my case. parameterized trigger run other job, but I don't need that. I need some values shared between some independent jobs and available to read/write in any time from any jobs. Shared Pipelines seems to be better for this purpose. But I can't understand how I can write value at JENKINS Server machine when Job is running on other machine? To be precisely, in my case jobs is running on some virtual machins, but the shared value must be stored in a specific file on JENKINS Servier file with specific path. I can't understand how I make it with Shared Library. Thank you for answer.

daniel-beck commented 8 months ago

This looks more like https://plugins.jenkins.io/metadata/ than the others suggested above. It looks like it does something novel (AFAICT) and potentially useful.

https://github.com/OlegGavri/gparms/blob/7e93fa1d6b00c088a7bc934ed6214f87ea085487/src/main/java/io/jenkins/plugins/GParamsReadStep.java#L71-L75 seems to implement path traversal (let name be ../config.xml), and makes the lookup path dependent on the working directory. It should involve the Jenkins home directory in the path, and require alphanumeric name up to a max length.

OlegGavri commented 8 months ago

This looks more like https://plugins.jenkins.io/metadata/ than the others suggested above. It looks like it does something novel (AFAICT) and potentially useful.

https://github.com/OlegGavri/gparms/blob/7e93fa1d6b00c088a7bc934ed6214f87ea085487/src/main/java/io/jenkins/plugins/GParamsReadStep.java#L71-L75 seems to implement path traversal (let name be ../config.xml), and makes the lookup path dependent on the working directory. It should involve the Jenkins home directory in the path, and require alphanumeric name up to a max length.

Thank you very much for your answer and for bug finding. I fix it. Metadata is seem to be more appropriate. But in my case value should be "global", not associated with Jobs, project and build etc. And gparams is very easy to use.

daniel-beck commented 8 months ago

Metadata is seem to be more appropriate. But in my case value should be "global", not associated with Jobs, project and build etc. And gparams is very easy to use.

To clarify, I'm not discouraging hosting of this plugin, just providing what I think is a better comparison. Metadata does something different, so there's a place for this plugin IMO.

OlegGavri commented 8 months ago

https://github.com/OlegGavri/gparms/blob/7e93fa1d6b00c088a7bc934ed6214f87ea085487/src/main/java/io/jenkins/plugins/GParamsReadStep.java#L71-L75 seems to implement path traversal (let name be ../config.xml), and makes the lookup path dependent on the working directory. It should involve the Jenkins home directory in the path, and require alphanumeric name up to a max length.

I have fixed this path traversal vulnerability

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The 'artifactId' from the pom.xml (gparams) is incorrect, it should be global-parameters ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 8 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The 'artifactId' from the pom.xml (gparams) is incorrect, it should be global-pipeline-parameters ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

OlegGavri commented 8 months ago

/hosting re-check

daniel-beck commented 8 months ago

I have fixed this path traversal vulnerability

Thanks. I recommend validation be done during execution. While I expect the constructor cannot be bypassed for a Pipeline step, I am not confident about that.

https://github.com/OlegGavri/gparms/blob/8a5af9e9ee2742150840e8215bf1392c2ffee25c/src/main/java/io/jenkins/plugins/Parameters.java#L7 is wrong as there may not be a system property, use Jenkins#getRootDir instead.

OlegGavri commented 7 months ago

I have fixed this path traversal vulnerability

Thanks. I recommend validation be done during execution. While I expect the constructor cannot be bypassed for a Pipeline step, I am not confident about that.

https://github.com/OlegGavri/gparms/blob/8a5af9e9ee2742150840e8215bf1392c2ffee25c/src/main/java/io/jenkins/plugins/Parameters.java#L7 is wrong as there may not be a system property, use Jenkins#getRootDir instead.

Thanks. I fix your recommendations.

OlegGavri commented 7 months ago

/hosting re-check

github-actions[bot] commented 7 months ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

NotMyFault commented 7 months ago

/request-security-scan

jenkins-cert-app commented 7 months ago

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

NotMyFault commented 7 months ago

Hey, I took a brief look at your hosting request and have some feedback for you:

You forgot to add a .mvn folder with the following files: https://github.com/jenkinsci/archetypes/tree/master/common-files/.mvn
You forgot to add a .github folder with the following files and subdirectories: https://github.com/jenkinsci/archetypes/tree/master/common-files/.github
Please add an appropriate package name to your class structure: https://github.com/OlegGavri/gparms/tree/master/src/main/java/io/jenkins/plugins
https://github.com/OlegGavri/gparms/blob/ae83e69f9929c3f6a6d462de81a02b406142c947/pom.xml#L41-L42 should match your jenkins.version specified
A JUnit test is mandatory to get a successful build after the hosting process.
https://github.com/OlegGavri/gparms/blob/ae83e69f9929c3f6a6d462de81a02b406142c947/pom.xml#L49-L52 is obsolete and should be removed
The steps added do not support the pipeline snippet generator:

OlegGavri commented 5 months ago

NotMyFault, Thank you very much for your notes. I try to fix everything and push to master bracnh.

OlegGavri commented 5 months ago

/hosting re-check

github-actions[bot] commented 5 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.426.3</jenkins.version> to at least 2.440.3 in your pom.xml. Take a look at the baseline recommendations.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

OlegGavri commented 5 months ago

/hosting re-check

github-actions[bot] commented 5 months ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

NotMyFault commented 3 months ago

/hosting re-check

github-actions[bot] commented 3 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The parent pom version '4.83' should be at least '4.85' or higher.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

NotMyFault commented 3 months ago

/request-security-scan

jenkins-cert-app commented 3 months ago

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

OlegGavri commented 1 month ago

/hosting re-check

github-actions[bot] commented 1 month ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

OlegGavri commented 1 month ago

/request-security-scan

Thank you. I wait for you decide.

jenkins-cert-app commented 1 month ago

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

OlegGavri commented 1 month ago

/hosting host

jenkins-infra / repository-permissions-updater