Continue maintenance for unleash-plugin repo (which is currently marked deprecated)

mhoffrog commented 2 months ago

Repository URL

https://github.com/mavenplugins/jenkins-unleash-plugin

New Repository Name

unleash-plugin

Description

This is to followup maintaining the already existing unleash-plugin repo. Due to the original founder did discontinue maintaining the maven-unleash-plugin I would like to continue with this one. Currently I have forked the existing repo at the URL mentioned above. unleash-plugin fork. Update by 10-Jul-2024: The fork relation has already been detached by GitHub support based upon my request.

You can find up to date implementations of the unleash-maven-plugin there as well: unleash-maven-plugin.

So I would like you to assign me appropriate commit access to repo https://github.com/jenkinsci/unleash-plugin.

GitHub users to have commit permission

@mhoffrog

Jenkins project users to have release permission

mhoffrog

Issue tracker

Jira

jenkins-cert-app commented 2 months ago

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository. It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command. Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.6)

github-actions[bot] commented 2 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: You must specify a <developerConnection> tag in your block in your pom.xml. You can use this sample: <developerConnection>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin</developerConnection>
:no_entry: Required: The parent pom version '3.57' should be at least '4.82' or higher.
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: mhoffrog (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: mhoffrog (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The <groupId> from the pom.xml should be io.jenkins.plugins instead of com.itemis.jenkins.plugins
:no_entry: Required: Repository 'https://github.com/mavenplugins/jenkins-unleash-plugin' is currently showing as forked from a jenkinsci org repository, this relationship needs to be broken

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

jenkins-cert-app commented 2 months ago

:x: Jenkins Security Scan failed. The Security team was notified about this.

mhoffrog commented 2 months ago

/hosting re-check

github-actions[bot] commented 2 months ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.426.3</jenkins.version> to at least 2.440.3 in your pom.xml. Take a look at the baseline recommendations.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

mhoffrog commented 2 months ago

/hosting re-check

github-actions[bot] commented 2 months ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

mhoffrog commented 2 months ago

/request-security-scan

jenkins-cert-app commented 2 months ago

The Jenkins Security Scan discovered 5 finding(s) :mag:.

Please follow the instructions below for every identified issues:

Implement the recommended fix to address the issue.
If you think it's a false positive, suppress the warning directly within the code.
Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

UnleashAction.java#257

``` Potential CSRF vulnerability: If UnleashAction#doSubmit connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

UnleashMavenBuildWrapper.java#557

``` Potential CSRF vulnerability: If DescriptorImpl#doFillVersionUpgradeStrategyItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

UnleashMavenBuildWrapper.java#547

``` Potential CSRF vulnerability: If DescriptorImpl#doFillCredentialsIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST ```

Stapler: Missing permission check

You can find detailed information about this finding here.

UnleashAction.java#257

``` Potential missing permission check in UnleashAction#doSubmit ```

UnleashMavenBuildWrapper.java#557

``` Potential missing permission check in DescriptorImpl#doFillVersionUpgradeStrategyItems ```

mhoffrog commented 2 months ago

/request-security-scan

jenkins-cert-app commented 2 months ago

The Jenkins Security Scan discovered 2 finding(s) :mag:.

Please follow the instructions below for every identified issues:

Implement the recommended fix to address the issue.
If you think it's a false positive, suppress the warning directly within the code.
Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Stapler: Missing permission check

You can find detailed information about this finding here.

UnleashAction.java#262

``` Potential missing permission check in UnleashAction#doSubmit ```

UnleashMavenBuildWrapper.java#562

``` Potential missing permission check in DescriptorImpl#doFillVersionUpgradeStrategyItems ```

mhoffrog commented 2 months ago

/request-security-scan

jenkins-cert-app commented 2 months ago

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

github-actions[bot] commented 2 months ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

mhoffrog commented 2 months ago

/request-security-scan

jenkins-cert-app commented 2 months ago

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

timja commented 2 months ago

Hi, can you instead send a pull request to add yourself to the existing repository please:

https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-unleash.yml

We can then get your access sorted out

mhoffrog commented 2 months ago

Hi, can you instead send a pull request to add yourself to the existing repository please:

@timja - Done - many thanks for your support!

jenkins-infra / repository-permissions-updater