Hosting request for testwheel-api

aprasanth3192 commented 1 month ago

Repository URL

https://github.com/Yakshna-Corporation/testwheel-trigger

New Repository Name

testwheel-api-plugin

Description

TestWheel- Jenkins Plugin. You use this plugin to trigger test automation through Jenkins CI.

GitHub users to have commit permission

@baskerGanesan @prakashp1987 @aprasanth3192

Jenkins project users to have release permission

baskerGanesan prakashp1987 prasantha

Issue tracker

GitHub issues

jenkins-cert-app commented 1 month ago

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository. It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command. Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.29.18)

github-actions[bot] commented 1 month ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88, prasantha (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The dependency org.json:json should be replaced with a dependency to the api plugin io.jenkins.plugins:json-api
:no_entry: Required: The dependency org.apache.httpcomponents.client5:httpclient5 should be replaced with a dependency to the api plugin io.jenkins.plugins:apache-httpcomponents-client-5-api
:no_entry: Required: The 'artifactId' from the pom.xml (api-plugin) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)
:no_entry: Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

jenkins-cert-app commented 1 month ago

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

mawinter69 commented 1 month ago

Please give you plugin a meaningful name instead of my-api or just api e.g. testwheel-trigger So the repo name should be testwheel-trigger-plugin and the artifactid should then be testwheel-trigger
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L126, use e.g. testwheelTrigger for the Symbol, this is what you will use in a pipeline job and apiCallBuilder doesn't give any hint what the step is doing
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L131 use TestWheel Trigger in the displayname so people know in the build step dropdown in a freestyle job what the step is doing
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L74 this code will not work when the job runs on an agent. You will need to use https://javadoc.jenkins.io/hudson/FilePath.html -> write()
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/resources/index.jelly#L3 please fill in a meaningful description here what the plugin is doing. This is shown in the plugin manager to users
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L15 use a better name that includes TestWheel
remove https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L19-L24, the plugin should be built with jdk11 for now
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L18 stick to the jenkins version that you have specified in the bom at line 30
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L38 the dependency is not required you get it implicitly
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L44 the dependency to structs is not required
https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L73 the dependency to common-io is not required
The code is limited to freestyle jobs because of https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L131, there is no reason for this limitation

aprasanth3192 commented 1 month ago

/hosting re-check

aprasanth3192 commented 2 weeks ago

@jenkinsci/jenkins-maintainers

Hello, I've made the required changes as per the feedback. Could you please review the updates and let me know if any further changes are needed? Thank you!

timja commented 2 weeks ago

/hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The 'artifactId' from the pom.xml (testwheel-trigger) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)
:no_entry: Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

timja commented 2 weeks ago

Hi please review the title and the description you haven't addressed the first feedback from https://github.com/jenkins-infra/repository-permissions-updater/issues/4116#issuecomment-2393412402

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)
:no_entry: Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

aprasanth3192 commented 2 weeks ago

@jenkinsci/jenkins-maintainers

I want to change my repository name to testwheel-api-plugin as mentioned in my POM.
We have updated username across jira, github and artifactory as prakashp1987 with all necessary permissions.

aprasanth3192 commented 2 weeks ago

@jenkinsci/jenkins-maintainers /hosting re-check

Hi. I have made a change as per requirement feedback. could you please review the updates and let me know if any further changes are needed. Thank you

timja commented 2 weeks ago

/hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
:no_entry: Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
:no_entry: Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
:no_entry: Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
:no_entry: Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)
:no_entry: Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)
:no_entry: Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)
:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

baskerganesan commented 2 weeks ago

Logged in using baskerGanesan

timja commented 2 weeks ago

/hosting re-check

github-actions[bot] commented 2 weeks ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

:no_entry: Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

baskerganesan commented 1 week ago

/hosting re-check

github-actions[bot] commented 1 week ago

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

aprasanth3192 commented 1 week ago

@jenkinsci/jenkins-maintainers /hosting re-check

Hi. I have made a change as per requirement feedback. could you please review the updates and let me know if any further changes are needed. Thank you

jenkins-infra / repository-permissions-updater