jenkins-infra / repository-permissions-updater

Artifactory permissions synchronization tool and data set
79 stars 1.05k forks source link

Update plugin-job-restrictions.yml #4166

Closed mPokornyETM closed 1 week ago

mPokornyETM commented 1 week ago

Link to GitHub repository

https://github.com/jenkinsci/job-restrictions-plugin/tree/master

When modifying release permission

@oleg-nenashev @mPokornyETM

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [ ] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [ ] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [ ] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

https://github.com/jenkinsci/job-restrictions-plugin/pull/176

### CD checklist (for submitters)
- [x] I have provided a link to the pull request in my plugin, which enables CD according to the documentation. 
### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

thx guys ;-)

timja commented 1 week ago

In your PR you have specified revision and changelist but you don't have a revision variable, can you check that against the recommend version formats in the enabling cd doc please? https://github.com/mPokornyETM/job-restrictions-plugin/blob/modernize-plugin/pom.xml#L12

mPokornyETM commented 1 week ago

In your PR you have specified revision and changelist but you don't have a revision variable, can you check that against the recommend version formats in the enabling cd doc please? https://github.com/mPokornyETM/job-restrictions-plugin/blob/modernize-plugin/pom.xml#L12

Mea culpa. Changed to same settings like in the lockable-resources-plugin

mPokornyETM commented 2 hours ago

@timja It is possible, that I missed the admin rights in this repository?

mPokornyETM commented 2 hours ago

@timja It is possible, that I missed the admin rights in this repository?

I think, this can fix it: https://github.com/jenkinsci/job-restrictions-plugin/pull/177 But I am not 100% sure how it works

timja commented 5 minutes ago

Sorted permissions