jenkins-infra / repository-permissions-updater

Artifactory permissions synchronization tool and data set
79 stars 1.05k forks source link

CD enable next-build-number #4168

Closed akomakom closed 1 week ago

akomakom commented 1 week ago

Link to GitHub repository

https://github.com/jenkinsci/next-build-number-plugin

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [ ] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [ ] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [ ] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

https://github.com/jenkinsci/next-build-number-plugin/pull/25

### CD checklist (for submitters)
- [x ] I have provided a link to the pull request in my plugin, which enables CD according to the documentation. 
### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

akomakom commented 1 week ago

@timja if I'm reading the auto CD setup instructions right, after this got merged I should be able to access tokens for my plugin at https://github.com/jenkinsci/next-build-number-plugin/settings/secrets/actions ...

Did I miss a step? https://www.jenkins.io/doc/developer/publishing/releasing-cd/#enable-cd-permissions

Thanks!

timja commented 1 week ago

They are there: image

akomakom commented 1 week ago

@timja looks like I don't have appropriate privileges to the repo. I thought perhaps that this process would fix that.

timja commented 1 week ago

Fixed