search

jenkins-infra / repository-permissions-updater

Artifactory permissions synchronization tool and data set
79 stars 1.06k forks source link

Amazon Web Services SDK 2 #4198

Closed basil closed 3 days ago

basil commented 3 days ago

Repository URL

https://github.com/basil/aws-java-sdk2-plugin

New Repository Name

aws-java-sdk2-plugin

Description

Amazon Web Services SDK 2

GitHub users to have commit permission

@basil

Jenkins project users to have release permission

basil

Issue tracker

Jira

jenkins-cert-app commented 3 days ago

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository. It takes ~10 minutes to complete.

Commands The bot will parse all comments, and it will check if any line start with a command. Security team only:
  • /audit-ok => the audit is complete, the hosting can continue :tada:.
  • /audit-skip => the audit is not necessary, the hosting can continue :tada:.
  • /audit-findings => the audit reveals some issues that require corrections :pencil2:.
Anyone:
  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:. It's only applicable when the previous audit required changes.
Only one command can be requested per comment.

(automatically generated message, version: 1.31.144)

jenkins-cert-app commented 3 days ago

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

timja commented 3 days ago

image

project users isn't free text and that will have been breaking the validation, I can remove you afterwards but AFAIK that field is used by the security team for assigning security issues to

timja commented 3 days ago

cc @Wadeck ^^

timja commented 3 days ago

/hosting re-check

github-actions[bot] commented 3 days ago

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

timja commented 3 days ago

You can ignore the artifactId check as this isn't really setup for multi-module plugins.

Would you be able to change the groupId to io.jenkins.plugins.aws-java-sdk or potentially: io.jenkins.plugins.aws-java-sdk2 to be clearer that its the 2 SDK?

Wadeck commented 3 days ago

What we are using is especially the 

security:
  contacts:
    jira: xxxx

field (in this repo) :)

basil commented 3 days ago

Would you be able to change the groupId to io.jenkins.plugins.aws-java-sdk or potentially: io.jenkins.plugins.aws-java-sdk2 to be clearer that its the 2 SDK?

Done in https://github.com/basil/aws-java-sdk2-plugin/commit/ce1dec68fbc7d674dab3e10cdf392d2b0625b63b

timja commented 3 days ago

/hosting host

jenkins-infra-bot commented 3 days ago

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/aws-java-sdk2-plugin

A Jira component named [aws-java-sdk2-plugin](https://issues.jenkins.io/issues/?jql=project+%3D+JENKINS+AND+component+%3D+ aws-java-sdk2-plugin)has also been created with basil as the default assignee for issues.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

Welcome aboard!