search

jenkins-infra / stats.jenkins.io

Revamped Jenkins Infra Stats Website as a part of GSoC 2024
https://new.stats.jenkins.io
3 stars 4 forks source link

fix(updatecli): Typo #41

Closed gounthar closed 5 days ago

gounthar commented 1 week ago

My suggestion regarding this typo got ignored.

gounthar commented 1 week ago

It's not consistent with the text of your message earlier in the manifest. My suggestion was not addressed, as it was neither marked as resolved, nor responded to, nor committed. 🙂 This is not an issue in itself, merely an observation. The suspected "typo" was not significant enough to request changes in your Pull Request; it was simply a minor nitpick, as this inconsistency caught my attention.

lemeurherve commented 1 week ago

This name concerns the manifest and isn't reused for PR title or commit message, while this target name is used for the commit message, following https://www.conventionalcommits.org convention. (A "chore: " is added as prefix by updatecli)

The fact that I've set them differently is intentional, not an inconsistency.

Your review consisted in a code suggestion to set an uppercase to the "bump" in the target name (same in this PR), did I addressed it?

Removing my request for change, still -1 on this change.

lemeurherve commented 1 week ago

My suggestion was not addressed, as it was neither marked as resolved, nor responded to, nor committed. 🙂

You're right I previously just answered it, now marked as resolved.