Closed shlomomdahan closed 2 days ago
Nice, thanks!
Overall, looks very nice! However, I see horizontal and vertical scrollbar. I guess it's because of.
the hook will fetch the data from the raw html file found on GitHub and parse it to get the VersionData dictionary
Although, If there's a way to get rid of the scrollbars. That would be pleasant. Is it possible @shlomomdahan ?
I checked it on mobile. The scrollbars are not present on smaller screens.
@Vandit1604 I added scrollbars to the larger tables to make it clear that there’s more data to see and to help navigate through it quicker. But if you think removing them would make the UI cleaner, I can make that change easily.
Also, I’m working on a PR to remove the sidebar as @krisstern requested. It'll replace it with a search bar and selector on the main page, along with a 'back to search' button to make it easy to start new searches.
Could we consider these updates for the next PR?
We should take the opinion of the other mentors involved before we remove them.
But if you think removing them would make the UI cleaner, I can make that change easily.
WDYT @krisstern @gounthar @lemeurherve about removing the scrollbar, at least for the smaller tables.
@Vandit1604 Oh, I didn't realize you meant you see the scrollbars on smaller tables as well. I don't see them on my end?
Can you share how it looks for you?
Thanks
When I go to plugin version page, scrollbars are already there.
This is how it looks when I open a small chart
Could you investigate @shlomomdahan why this is happening?
@Vandit1604 That's strange! do you see that with the deployment link as well or just locally?
If locally, can you make sure your branch is up to date by pulling the latest version?
I haven't tested this PR locally since there were some changes suggested by Kris. I see this behavior on the Deployment link: https://deploy-preview-50--stats-jenkins-io.netlify.app/plugin-versions
@Vandit1604 which browser are you using?
I'm on Brave right now. On Firefox, the scrollbars are absent. I checked, and scrollbars are also present on Chrome for me.
@Vandit1604
That's very strange. I will try to see if I can reproduce the same issue. Otherwise, let's scrap the scrollbars to avoid this issue.
@shlomomdahan Have you found a way to handle the issue with the scrollbars yet? This appears to be a blocker at the moment.
@Vandit1604 @krisstern
I was not able to reproduce the issue on my end. Still, I changed overflow from 'scroll' to 'auto'. Can you check if that works?
BTW - I think we should still merge this and move on. #58 will likely fix this issue.
Let's make sure we review this PR properly before merging prematurely.
@Vandit1604 Please see if you could reproduce the issue still.
Thanks @Vandit1604!
This PR adds the plugins version by Jenkins version page.