search

jenkins-infra / stories

A static site for the Jenkins is the way
https://stories.jenkins.io
Apache License 2.0
3 stars 16 forks source link

Replace manifest's icon from one from jenkins.io #20

Closed NotMyFault closed 1 year ago

halkeye commented 1 year ago

I'm not sure what this is fixing. The manifest has an icon, and i think the favicon from jenkins.io is small, and manifest wants like 512

image

NotMyFault commented 1 year ago

I'm not sure what this is fixing.

This PR exchanges the gatsby icon with the Jenkins one, to prevent putting the gatsby logo in place, which currently is distributed as https://stories.jenkins.io/favicon-32x32.png?v=53aa06cf17e4239d0dba6ffd09854e02

halkeye commented 1 year ago

This is so weird. I clearly (as screenshotted) see the jenkins icon, but https://realfavicongenerator.net/favicon_checker?protocol=https&site=stories.jenkins.io does show the gatsby icon for the app icon manifest.

halkeye commented 1 year ago 
curl -qs 'https://stories.jenkins.io/' | tr '<' '\n' | grep manifest
link data-react-helmet="true" href="/site.webmanifest" rel="manifest"/>
link rel="manifest" href="/manifest.webmanifest" crossorigin="anonymous"/>

Looks like we have two manifest, one from the site layout plugin, one from the manifest plugin

halkeye commented 1 year ago

So I think the proper fix is to 1) remove that gatsby plugin 2) update gatsby-plugin-jenkins-layout to take in name and shortname.

I can handle #2 as soon as i finish breakfast and my electronics work.

NotMyFault commented 1 year ago

So I think the proper fix is to 1) remove that gatsby plugin

Done 1), I also removed the obsolete gatsby png.